fix: handle bare dict annotations in construct_type - #3386
Closed
Resurgamz wants to merge 1 commit into
Closed
Conversation
Avoid unpacking missing type arguments when model construction sees an unparameterized dict field. Fixes openai#3341
Resurgamz
marked this pull request as ready for review
June 9, 2026 01:43
Author
|
@openai/sdks-team @apcha-oai Could you please help review and approve this PR? Thanks. |
Author
|
@apcha-oai Friendly follow-up: could you please help review this PR when you have a chance? Thanks. |
Contributor
|
Thank you for the contribution. The missing type arguments for bare Closing this PR because the merged change resolves the same crash. Please use a release containing #3760 when available; the fix is not included in v3.11.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dictvalues unchanged during model construction when no value type argument is available.BaseModel.construct()with a field annotated as plaindict.Changes
src/openai/_models.pyget_args(dict)is empty.tests/test_models.pydictfields.Test Plan
PYTHONPATH="$PWD/src" /home/ut006460@uos/project/openai-python/.venv/bin/python -m pytest tests/test_models.py -k bare_dictionary -n 0PYTHONPATH="$PWD/src" /home/ut006460@uos/project/openai-python/.venv/bin/python -m pytest tests/test_models.py -n 0/home/ut006460@uos/project/openai-python/.venv/bin/ruff format tests/test_models.py src/openai/_models.py/home/ut006460@uos/project/openai-python/.venv/bin/ruff check tests/test_models.py src/openai/_models.pyFixes #3341