Skip to content

fix: safely support bulk-scan options and flexible container CSV ordering - #197

Open
mldangelo-oai wants to merge 4 commits into
mainfrom
mdangelo/codex/secure-interactive-bulk-scan-options
Open

fix: safely support bulk-scan options and flexible container CSV ordering#197
mldangelo-oai wants to merge 4 commits into
mainfrom
mdangelo/codex/secure-interactive-bulk-scan-options

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Attribution

Builds directly on #175 by @dipeshbabu and preserves the original authored commit. Thank you, Dipesh, for the interactive bulk-scan option fix.

Summary

  • retain the original typed-CLI fix so interactive discovery accepts worker, mode, retry, plugin, Python, model, and Codex settings
  • detect bulk scans after global CLI options and reject every customer-container invocation without a repository CSV
  • accept valid container CSV scans regardless of whether scan options appear before or after the CSV
  • preserve command help, schemas, LLM metadata, existing Git credential setup, and restricted-host Landlock safeguards
  • forward help and metadata flags even when they immediately follow an option with a missing value
  • honor -- option boundaries so metadata-shaped CSV filenames cannot bypass Landlock, and inject mandatory sandbox options before the terminator
  • add end-to-end interactive discovery coverage, comprehensive container argument-order regressions, and user-facing bulk-scan documentation

Fixes #45.

Verification

  • full SDK suite: 723 passed, 5 platform/integration skips, 0 failures
  • focused CLI, container-entrypoint, discovery, and multiscan suites: 126 passed
  • original container-bypass reproducer now rejects both direct and globally prefixed discovery
  • metadata- and override-shaped filenames after -- cannot suppress sandbox configuration
  • public SDK imports and CLI startup verified under Node.js 22, 24, and 26
  • packed npm installation verified all 95 bundled plugin files and 179 archive entries
  • pnpm run types
  • pnpm run format
  • pnpm run build
  • pnpm pack --pack-destination /private/tmp/codex-security-followup-package
  • npm_config_cache=/private/tmp/codex-security-followup-npm-cache pnpm run check:package /private/tmp/codex-security-followup-package/openai-codex-security-0.1.5.tgz
  • shellcheck docker/entrypoint.sh
  • sh -n docker/entrypoint.sh
  • git diff --check

@github-actions github-actions Bot added the bug Something isn't working label Aug 1, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review the exact current head e96d424, focusing on fail-closed container argument classification, global-option prefixes, option-first CSV detection, metadata/help behavior, and restricted-host Landlock enforcement.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e96d424a08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docker/entrypoint.sh
@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: e96d424a08

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review the exact current head fe12bfd, focusing on option-terminator state, metadata-looking CSV filenames, correct pre-terminator Landlock injection, global-option prefixes, and flexible CSV ordering.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe12bfd011

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docker/entrypoint.sh Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: fe12bfd011

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review Please review the exact current head 49d2172, including pre-terminator metadata after value-taking flags, post-terminator positional filenames, restricted-host Landlock enforcement, globally prefixed discovery, and option-first CSV scans.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 49d2172013

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 49d2172013

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container entrypoint rejects bulk-scan with a CSV whenever an option precedes it

2 participants