fix: include informational findings in report.md projection - #156
Closed
mangeshraut712 wants to merge 1 commit into
Closed
fix: include informational findings in report.md projection#156mangeshraut712 wants to merge 1 commit into
mangeshraut712 wants to merge 1 commit into
Conversation
informational is a valid findings severity and is exported to SARIF/CSV, but report.md filtered it out via REPORTABLE_SEVERITIES, so all- informational scans rendered as "No findings". Include informational in the reportable set and cover it with a projection unit test. Fixes #48
|
Note You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
informationalinREPORTABLE_SEVERITIESsoreport.mdlists those findings instead of showing No findings when a scan is informational-only (fixes informational findings are exported to SARIF and CSV but dropped from report.md, which then reports no findings #48).test_report_projection_informational.pycovering the projection behavior.Note for maintainers
Per CONTRIBUTING, this public repo is a one-way mirror. This PR is a ready-to-port reference implementation for the canonical tree.
Test plan
python3 sdk/typescript/_bundled_plugin/scripts/test_report_projection_informational.pyMade with Cursor