Skip to content

Skip body building when HTTP call body is absent #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Sep 2, 2026
+37 −2
Merged

Skip body building when HTTP call body is absent #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutorBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,10 @@ private RequestExecutor buildRequestExecutor() {
case HttpMethod.POST:
case HttpMethod.PUT:
case HttpMethod.PATCH:
return new WithBodyRequestExecutor(
httpMethod, redirect, auth, definition.application(), body);
return body != null
? new WithBodyRequestExecutor(
httpMethod, redirect, auth, definition.application(), body)
: new WithoutBodyRequestExecutor(httpMethod, redirect, auth);
case HttpMethod.DELETE:
case HttpMethod.HEAD:
case HttpMethod.OPTIONS:
Expand Down
21 changes: 21 additions & 0 deletions impl/test/src/test/java/io/serverlessworkflow/impl/test/HTTPWorkflowDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,27 @@ void callHttpPost_should_return_created_firstName() throws Exception {
});
}

@Test
void callHttpPost_without_body_should_not_throw() throws Exception {
mockServer.enqueue(new MockResponse(204, Headers.of(), ""));

assertDoesNotThrow(
() ->
appl.workflowDefinition(
readWorkflowFromClasspath("workflows-samples/call-http-post-no-body.yaml"))
.instance(Map.of())
.start()
.join());

RecordedRequest recordedRequest = mockServer.takeRequest();
SoftAssertions.assertSoftly(
softly -> {
softly.assertThat(recordedRequest.getMethod()).isEqualTo("POST");
softly.assertThat(recordedRequest.getUrl()).asString().contains("/api/v1/authors");
softly.assertThat(recordedRequest.getBodySize()).isEqualTo(0);
});
}
Comment thread
fjtirado marked this conversation as resolved.

@Test
void testCallHttpDelete() throws IOException, InterruptedException {
mockServer.enqueue(new MockResponse(204, Headers.of(), ""));
Expand Down
12 changes: 12 additions & 0 deletions impl/test/src/test/resources/workflows-samples/call-http-post-no-body.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
document:
dsl: 1.0.0-alpha1
namespace: test
name: call-http-post-no-body
version: 1.0.0
do:
- postAuthors:
call: http
with:
method: post
endpoint:
uri: http://localhost:9876/api/v1/authors
Loading