Repository navigation
Conversation
ggrace519
marked this pull request as draft
September 6, 2026 13:27
Guest Open WebUI pages could invoke the full privileged desktop API. Remote connections received Open Terminal keys. TLS was disabled globally. Downloads of Python, llama.cpp, and GGUF weights were not checksummed. This allowlists guest IPC, scopes TLS exceptions, verifies artifacts, sandboxes shell windows, pins Electron 39.8.10, and keeps Access/SSO login inside the app. Co-authored-by: Grok 4.6 <grok@x.ai>
ggrace519
force-pushed
the
feat/security-hardening
branch
from
September 6, 2026 13:36
634f6c0 to
f91d995
Compare
ggrace519
marked this pull request as ready for review
September 6, 2026 13:40
Windows node-pty throws "Cannot resize a pty that has already exited" from the main process (Linux: ioctl EBADF). That uncaught exception killed the whole app when the console tab resized during a server restart. Closes open-webui#255 Co-authored-by: Grok 4.6 <grok@x.ai>
Spawn cmd.exe instead of sh so the helper is exercised against real conpty, tear the agent down so node:test can exit, and compare confinedModelPath with path.resolve so the suite is not POSIX-only. Co-Authored-By: Grok 4.6 <grok@x.ai>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guest Open WebUI pages (including remote connections) could invoke the full privileged desktop API via
window.electronAPI[requestData.type]. Remote webviews also received Open Terminal API keys. TLS verification was disabled on every Chromium session. Python, llama.cpp, and Hugging Face GGUF downloads were not checksummed. Linux always launched with--no-sandbox. Packaged Electron fuses were left at insecure defaults. macOS/Windows releases published unsigned fallbacks on codesign failure.This PR allowlists guest IPC, scopes TLS exceptions to user-added connection origins, verifies downloaded artifacts, sandboxes shell windows, pins Electron to 39.8.10 (GHSA-h7rp-cf8h-j98x), keeps Cloudflare Access / SSO login inside the app, and fails closed on unsigned releases.
Production shell windows load
app://renderer/…instead offile://. Dev (npm run dev) is unchanged.Overlaps (maintainers may want to close or rebase):
send()and does not indexelectronAPIwith guest stringsFork-only docs (
CLAUDE.md,DECISIONS.md, develop-branch model) are not in this PR.Security
send()allowlist:token:update,app:info,app:data,window:isFocusedwill-attach-webviewforcessandbox/contextIsolation/ no NodeopenExternalishttp:/https:/mailto:only?blobs=true)--host/--port/--models-diralways from the desktop--no-sandboxonly for AppImage/snap/Flatpak/unpackaged/ELECTRON_DISABLE_SANDBOX=1sandbox: true; drop@electron-toolkit/preloadwindow.electronFixes
app:data(nullinstead of{}— Open WebUI+layout.sveltedoes not importappData)Infrastructure
npm test(23node:testcases on the security helpers)src/main+ preloadRelated Issues
Related to #175, #165. Does not close those if #218 is the intended path for OAuth host allowlisting.
Verification
Contributor License Agreement