fix(resolver): load registry files when the root path is dot-prefixed - #1666
Open
NimrodAvni78 wants to merge 2 commits into
Open
fix(resolver): load registry files when the root path is dot-prefixed#1666NimrodAvni78 wants to merge 2 commits into
NimrodAvni78 wants to merge 2 commits into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-04 14:26 UTC Review the latest changes. Status above doesn't look right?
|
The directory walker pruned the registry root when its final path component started with a dot (e.g. `-r .`, or a `.`-named registry dir), because walkdir yields the root as an entry whose file_name is "." and is_hidden matched it. Exempt the root (depth 0) from the hidden filter so a dot-rooted registry loads its own spec files while genuinely hidden sub-entries stay skipped.
NimrodAvni78
force-pushed
the
fix/loader-dot-rooted-registry
branch
from
August 4, 2026 05:58
a1d97c2 to
0f4371d
Compare
NimrodAvni78
marked this pull request as ready for review
August 4, 2026 06:05
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
=======================================
- Coverage 81.4% 81.4% -0.1%
=======================================
Files 131 131
Lines 11714 11714
=======================================
- Hits 9537 9536 -1
- Misses 2177 2178 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1558
The directory walker pruned the registry root when its final path component started with a dot (e.g.
-r ., or a.-named registry dir), because walkdir yields the root as an entry whose file_name is "." and is_hidden matched it. Exempt the root (depth 0) from the hidden filter so a dot-rooted registry loads its own spec files while genuinely hidden sub-entries stay skipped.