Modules: add opentelemetry-proto module with protobuf definitions - #47
Conversation
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <francesco.gualazzi@stealthium.io>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
|
For testing this PR you will need to sync the submodule first. and then you can run the build steps |
|
Why use a git submodule here ? we could add it as a lazy dependency in the |
@agagniere good question 👍🏼 Can we do the same with lazy dependencies? I genuinely haven't used them. |
|
We absolutely can pin dependencies (lazy or not): zig fetch --save=opentelemetry_proto git+https://github.com/open-telemetry/opentelemetry-proto#v1.11.0note the |
|
Do we handle the intricacies / weirdness of OTLP json with hex encoding? |
|
@jaronoff97 are you referring to what's been addressed in this PR ? |
|
@agagniere not exactly, the OTLP json object's trace id should be treated as a hex (this is why otel go has a custom deserialization method) instead of a string. i have a fork of zig-protobuf to handle this case. Check the spec deviations here |
@jaronoff97 seems like we need a dedicated issue for this. I'll create one, but that's nothing that concerns this PR, correct? |
|
I don't think it should block this one, no, but it's something we should be aware of for powering the json representation off of these protos. |
Got it thanks, so we could then avoid the submodule? |
|
@agagniere the lazyDep is working but I can't force-push on this branch. |
Reason for this PR
Closes #19
Details
We add a new folder in the monorepo, hosting the module with the protobuf-generated code.
Same dependencies and buld steps are ported to the main
build.zig.A new
buildfolder component is made for the protobuf module.Documentation is updated to reflect the multiple modules structure.