Remove packaging runtime dependency from SQLAlchemy instrumentation - #4915
Open
saisharan0103 wants to merge 1 commit into
Conversation
…pendency of `opentelemetry-instrumentation-sqlalchemy` Closes open-telemetry#4887
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the direct
packaging >= 21.0runtime dependency fromopentelemetry-instrumentation-sqlalchemy.The dependency was only needed because SQLAlchemy instrumentation imported
packaging.version.parseto comparesqlalchemy.__version__against1.4before installing or removing SQLAlchemy 1.4+ wrappers. This forced the auto-instrumentation injector to addpackagingto the target application'sPYTHONPATH, even though PEP 440 version parsing is already intended to come fromopentelemetry-instrumentationafter #4882.This changes the SQLAlchemy instrumentation module to use
Versionfromopentelemetry.instrumentation._packaging.versionand compareVersion(sqlalchemy.__version__).releaseto(1, 4)at the existing four version-gated call sites.A focused regression test now asserts that the SQLAlchemy instrumentation package metadata no longer lists
packagingas a direct runtime dependency. The existing SQLAlchemy 1.4/2.x tox variants continue to cover the version-gated wrapper behavior.Fixes #4887
ruff check instrumentation/opentelemetry-instrumentation-sqlalchemy/pyproject.toml instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py instrumentation/opentelemetry-instrumentation-sqlalchemy/tests/test_sqlalchemy.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.