Expose capture_parameters in pymssql instrumentation - #4909
Open
saisharan0103 wants to merge 1 commit into
Open
Conversation
…ssql`: expose `capture_parameters` Closes open-telemetry#4792
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4792 reports that
opentelemetry-instrumentation-pymssqldoes not exposecapture_parameterseven though the pymssql instrumentor delegates tracing to the shared dbapi wrapper.Root cause:
PyMSSQLInstrumentor._instrumentcalleddbapi.wrap_connectwithout reading or forwardingcapture_parameters,instrument_connectiononly acceptedconnectionandtracer_provider, and_PyMSSQLDatabaseApiIntegrationcan only enable inheritedDatabaseApiIntegrationparameter capture when the dbapi factory receives the flag.This mirrors the psycopg2 forwarding surface by:
capture_parametersfrom_instrumentkwargs with aFalsedefaultcapture_parameterstodbapi.wrap_connectcapture_parameterstoinstrument_connectiondbapi.instrument_connectionNo pymssql-specific parameter formatting is added;
_PyMSSQLDatabaseApiIntegrationcontinues to inheritDatabaseApiIntegration.__init__so the shared dbapi integration stores the flag.ruff check instrumentation/opentelemetry-instrumentation-pymssql/src/opentelemetry/instrumentation/pymssql/__init__.py instrumentation/opentelemetry-instrumentation-pymssql/tests/test_pymssql_integration.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.