Expose capture_parameters in sqlite3 instrumentation - #4908
Open
saisharan0103 wants to merge 1 commit into
Open
Conversation
…ite3`: expose `capture_parameters` Closes open-telemetry#4793
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4793.
The sqlite3 instrumentor delegates query execution wrapping to
opentelemetry.instrumentation.dbapi, but it did not expose or forward dbapi'scapture_parametersoption. This meantSQLite3Instrumentor().instrument(capture_parameters=True)silently dropped the option beforedbapi.wrap_connectwas called, andSQLite3Instrumentor.instrument_connection(...)had nocapture_parametersparameter to pass todbapi.instrument_connection.This change mirrors the dbapi option threading used by other instrumentors:
capture_parametersfrom_instrumentkwargs with aFalsedefault.capture_parametersintodbapi.wrap_connectfor bothsqlite3andsqlite3.dbapi2modules.capture_parameters: bool = Falsetoinstrument_connection, documents it in the method docstring, and forwards it todbapi.instrument_connection.ruff check instrumentation/opentelemetry-instrumentation-sqlite3/src/opentelemetry/instrumentation/sqlite3/__init__.py instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.