Check if stdout actually contains "Package:" to surely confirm it's a real package. (Fix #18)#23
Open
michadasis wants to merge 1 commit into
Open
Check if stdout actually contains "Package:" to surely confirm it's a real package. (Fix #18)#23michadasis wants to merge 1 commit into
michadasis wants to merge 1 commit into
Conversation
Contributor
Author
|
This fixes #18 |
Contributor
Author
|
This issue, theoretically speaking shouldn't happen on pacman to begin with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exit code 0 alone is not enough because virtual packages (e.g. freecad) also exit 0 but produce no real package record (In this example freecad has no installation candidate since they moved to snap/flatpak). I made it check that stdout contains an actual "Package:" field to confirm it is a real, installable package.