Skip to content

Prevent ESC from discarding edits#212

Open
ArizmendiWan wants to merge 1 commit into
open-rmf:mainfrom
ArizmendiWan:fix-esc
Open

Prevent ESC from discarding edits#212
ArizmendiWan wants to merge 1 commit into
open-rmf:mainfrom
ArizmendiWan:fix-esc

Conversation

@ArizmendiWan

Copy link
Copy Markdown
Contributor

Bug fix

Fix applied

Prevent Escape from closing the script environment manager and node/edge edit popover when focus is inside an active editing field. Escape still closes these surfaces when focus is outside text/code editing controls.

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by: GPT-5.5 with codex

Signed-off-by: ArizmendiWan <2311602492@qq.com>
@mxgrey mxgrey added this to PMC Board Jul 2, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in PMC Board Jul 2, 2026

@mxgrey mxgrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out, and the behavior is exactly what I hoped for!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants