Remove docker/ directory#145
Merged
Merged
Conversation
The docker/ image bundles OQS-OpenSSL so docker/minitest.py can exercise PQ-TLS interop. But liboqs-python does not add PQ support to Python, so there is no reason to test that here. Testing of PQ-TLS interoperability involving oqs-provider or OQS-OpenSSL should happen in oqs-provider or oqs-demos, not here. The easy-onboarding use case the docker setup originally addressed is now covered by the root Dockerfile plus liboqs-python's runtime auto- install of liboqs. docker/Dockerfile-simple overlaps in purpose with the root Dockerfile and isn't referenced anywhere. Thus the docker/ folder is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docker/ image bundles OQS-OpenSSL so docker/minitest.py can exercise PQ-TLS interop. But liboqs-python does not add PQ support to Python, so there is no reason to test that here. Testing of PQ-TLS interoperability involving oqs-provider or OQS-OpenSSL should happen in oqs-provider or oqs-demos, not here.
The easy-onboarding use case the docker setup originally addressed is now covered by the root Dockerfile plus liboqs-python's runtime auto- install of liboqs. docker/Dockerfile-simple overlaps in purpose with the root Dockerfile and isn't referenced anywhere. Thus the docker/ folder is no longer needed.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Closes #94.