Skip to content

1.3.7: self-update safety fixes (#46) - #47

Merged
sd88me merged 2 commits into
mainfrom
fix/self-update-safety-copy
Nov 20, 2026
Merged

sd88me merged 2 commits into
mainfrom
fix/self-update-safety-copy

Conversation

@sd88me

@sd88me sd88me commented Nov 19, 2026

Copy link
Copy Markdown
Member

Fixes #46.

What and why

An update of the Manager by itself could leave it unlisted (#46, MPC One+, 3.10.1.12). Its folder is large, so the safety copy goes beside it on the same drive and takes minutes. A power cycle mid-copy left .pm-snap-plugin-manager-g2, which blocked every later update. The failed run then still rewrote plugin.json with a binary name that isn't in the folder, and MPC dropped the Manager.

  • A leftover safety copy is removed when the plugin folder is there. A complete one (<snap>.done) is put back when the folder is gone. An incomplete one with no folder is reported and kept.
  • Rollback moves the failed folder aside and deletes it only once the safety copy is back.
  • A same-drive safety copy needs twice the folder size free, because the installer stages a second copy.
  • plugin.json is written only after a successful install. vst2.sh --json keeps a working one and never names a missing binary (vst2_migrate.sh --json: keep a working plugin.json, never name a missing binary mpc-vst-plugins#1045, header regenerated).
  • Version 1.3.7. It carries the 1.3.6 changes too; 1.3.6 was yanked (back to draft).

Not addressed here: the folder is big because it holds three copies of the skin (Plugin Skins, .dark, .light).

Checks

  • tests/run.sh (full, all sections OK); new safety cases for the leftover copy (with folder, complete without, incomplete without) and vst2 cases for the plugin.json rules
  • Device-verified: offline only

🤖 Generated with Claude Code

https://claude.ai/code/session_01CpoP2r5JUpLdH8zRMecf2A

sd88me and others added 2 commits November 20, 2026 10:57
…y after a successful install (#46)

- A safety copy left by an update that was cut off (power cycle) is removed when the plugin folder is there; a complete one
  (marked <snap>.done) is put back when the folder is gone; an incomplete one with no folder is reported, never guessed.
- A rollback moves the failed folder aside and deletes it only once the safety copy is back in place.
- A safety copy on the plugin's own drive needs twice the folder free (the installer stages a second copy).
- apply.sh writes plugin.json only after the install succeeded; vst2.sh --json (mpc-vst-plugins #1045) keeps a plugin.json
  whose binary is in the folder and never names a missing one.
- apply.log says when the safety copy starts and how big it is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CpoP2r5JUpLdH8zRMecf2A
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CpoP2r5JUpLdH8zRMecf2A
@sd88me
sd88me merged commit 5276121 into main Nov 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-update 1.3.5 to 1.3.6 left the Manager unlisted: plugin.json rewritten to a binary that isn't in the folder

1 participant