Repository navigation
1.3.7: self-update safety fixes (#46) - #47
Merged
Merged
Conversation
…y after a successful install (#46) - A safety copy left by an update that was cut off (power cycle) is removed when the plugin folder is there; a complete one (marked <snap>.done) is put back when the folder is gone; an incomplete one with no folder is reported, never guessed. - A rollback moves the failed folder aside and deletes it only once the safety copy is back in place. - A safety copy on the plugin's own drive needs twice the folder free (the installer stages a second copy). - apply.sh writes plugin.json only after the install succeeded; vst2.sh --json (mpc-vst-plugins #1045) keeps a plugin.json whose binary is in the folder and never names a missing one. - apply.log says when the safety copy starts and how big it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpoP2r5JUpLdH8zRMecf2A
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpoP2r5JUpLdH8zRMecf2A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46.
What and why
An update of the Manager by itself could leave it unlisted (#46, MPC One+, 3.10.1.12). Its folder is large, so the safety copy goes beside it on the same drive and takes minutes. A power cycle mid-copy left
.pm-snap-plugin-manager-g2, which blocked every later update. The failed run then still rewroteplugin.jsonwith a binary name that isn't in the folder, and MPC dropped the Manager.<snap>.done) is put back when the folder is gone. An incomplete one with no folder is reported and kept.plugin.jsonis written only after a successful install.vst2.sh --jsonkeeps a working one and never names a missing binary (vst2_migrate.sh --json: keep a working plugin.json, never name a missing binary mpc-vst-plugins#1045, header regenerated).Not addressed here: the folder is big because it holds three copies of the skin (
Plugin Skins,.dark,.light).Checks
tests/run.sh(full, all sections OK); newsafetycases for the leftover copy (with folder, complete without, incomplete without) andvst2cases for the plugin.json rules🤖 Generated with Claude Code
https://claude.ai/code/session_01CpoP2r5JUpLdH8zRMecf2A