Repository navigation
1.3.6: fixes for #5, #10, #13, #17, #22, the theme after an update, and two APPLY fixes - #45
Merged
Merged
Conversation
…p uid matching across catalog entries - #17: percent-encode the path in the file:// URL for local zips - #10: manifest_str decodes JSON escapes (\u03c0ToniC -> πToniC) - #22: when an installed folder's mpc-plugin.json id names a catalog entry, only that entry matches (no uid fallback) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpoP2prQZ6KeK3GtEkzmBY
…skin in place An update brings the packaged light skin back while the saved theme may be dark. The swap was already queued but never shown. The first start after that now prepares it and opens the restart prompt (CANCEL keeps it queued). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpoP2prQZ6KeK3GtEkzmBY
… folder), #22 (shared uid) Co-Authored-By: Claude <noreply@anthropic.com>
…d, a clear error when temporary space is short REMOVE needs the package's uninstall.sh, so every queued removal downloaded and unpacked its whole zip into /tmp/openmpc-pm (RAM) before anything ran. Removing every plugin on a Force filled it and failed as "could not be unpacked". Removals now unpack only the top-level files, each zip is deleted once unpacked, leftovers from a failed APPLY are cleared, and a package that will not fit says so before downloading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpoP2rYBzwj7RsAk3nfygS
A plugin deleted by another tool kept its MPC.settings entry, so the manager counted it installed and UPDATE ALL put it back where it was deleted (the internal SD on a Force) instead of on the picked drive. An entry whose file is gone while its Synths folder is there now reads as not installed; a drive that is not mounted keeps its plugins listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpoP2rYBzwj7RsAk3nfygS
…table (#5) The 'has no install location' message covered the Synths folders and the addins folder alike; a Live 1 report listed usable Synths folders and still got it. Co-Authored-By: Claude <noreply@anthropic.com>
…Hub link per plugin in its details (#13) Co-Authored-By: Claude <noreply@anthropic.com>
…gin-manager into claude/inspiring-edison-mc6tr9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
file://address is percent-encoded).folderwritten with JSON escapes (πToniC) is read asπToniC.mpc-plugin.jsonid names a catalog entry matches only that entry. Machinemodule's catalog entry lists the same VST uid that the Gen2 package ships, so one Gen2 install showed as both entries./data/mpc-addinsnow says so, instead of "has no install location". Whether this is the Live 1 reporter's cause is not confirmed.ccr-e23e516c-q253dk: removals unpack only the package scripts, zips go once unpacked, and a clear error when temporary space is short; an MPC.settings entry whose plugin folder was deleted is not an install.Feature
Tests: a new
regresssection covers #17, #10, #22 and #5, and thewebsection checks the #13 links. The full suite passes. Each new regression test failed when its fix was removed, except the theme-after-update check, which was not checked that way.Not tested on a device: the theme fix, the #13 web page and the #5 message are offline-tested only. #11 (data wheel) is not in this PR.
Closes #10, #13, #17, #22. Refs #5.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CpoP2tNiHYD3SLwjUsaPkY