You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is addressing #1278.
I use this myself and be happy to address any problems or issues.
If this kind of change is not wanted, please let me know why :)
Thanks for considering my contribution @jihanyang .
With the last commit 9bc206c I refactored the Waymo MPPNet configuration and added a test script in order to demonstrate that it does not change any configurations.
The mppnet_e2e_memorybank_inference_16frames configuration differs in TRANS_INPUT and hidden_dim, however, I created the baseline based on instructions inside the original mppnet_e2e_memorybank_inference config. I am not sure if this change was perhaps just not correctly documented, and as the configuration was not provided anyway, I would keep it as is, and add another commit to remove the test script again, and the original mppnet configuration files.
Hi @demmerichs
We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is addressing #1278.
I use this myself and be happy to address any problems or issues.
If this kind of change is not wanted, please let me know why :)