Skip to content

Fixes 604: fix nls icon for safari #27783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrabantipaul-collate merged 5 commits into from
Apr 29, 2026

Merge branch 'main' into fix-nls-icon-safari

36d3201
Select commit
Loading
Failed to load commit list.
Merged

Fixes 604: fix nls icon for safari #27783

Merge branch 'main' into fix-nls-icon-safari
36d3201
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / [open-metadata-ui] SonarCloud Code Analysis succeeded Apr 28, 2026 in 6m 39s

Quality Gate passed

Issues
1070 New issues
0 Accepted issues

Measures
17 Security Hotspots
0.0% Coverage on New Code
3.8% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 188 in src/components/common/TableDataCardV2/TableDataCardV2.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG0uzXVW2Rep05lwU&open=AZ3UG0uzXVW2Rep05lwU&pullRequest=27783

Check warning on line 67 in src/components/Alerts/DestinationFormItem/TeamAndUserSelectItem/TeamAndUserSelectItem.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Use `.includes()`, rather than `.indexOf()`, when checking for existence. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG39rXVW2Rep05l1p&open=AZ3UG39rXVW2Rep05l1p&pullRequest=27783

Check warning on line 120 in src/components/Glossary/GlossaryTerms/tabs/RelatedTerms.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG3IhXVW2Rep05l0V&open=AZ3UG3IhXVW2Rep05l0V&pullRequest=27783

Check warning on line 49 in src/components/common/atoms/TagChip/TagChip.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UGz0UXVW2Rep05luX&open=AZ3UGz0UXVW2Rep05luX&pullRequest=27783

Check warning on line 175 in src/components/WorkflowDefinitions/WorkflowBuilder/CustomNodes.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG2mwXVW2Rep05lzh&open=AZ3UG2mwXVW2Rep05lzh&pullRequest=27783

Check failure on line 93 in src/components/BlockEditor/Extensions/Callout/Callout.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `.dataset` over `getAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UGzfQXVW2Rep05lt-&open=AZ3UGzfQXVW2Rep05lt-&pullRequest=27783

Check warning on line 60 in src/components/MyData/CustomizableComponents/CustomiseGlossaryTermDetailPage/CustomiseGlossaryTermDetailPage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG133XVW2Rep05lx6&open=AZ3UG133XVW2Rep05lx6&pullRequest=27783

Check warning on line 189 in src/components/OntologyExplorer/utils/graphStyles.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Use the "RegExp.exec()" method instead. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG4muXVW2Rep05l2v&open=AZ3UG4muXVW2Rep05l2v&pullRequest=27783

Check warning on line 181 in src/components/common/TierCard/TierCard.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG0sOXVW2Rep05lwQ&open=AZ3UG0sOXVW2Rep05lwQ&pullRequest=27783

Check warning on line 114 in src/components/WorkflowDefinitions/WorkflowBuilder/NodeConfigSidebar.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG2gtXVW2Rep05lzR&open=AZ3UG2gtXVW2Rep05lzR&pullRequest=27783

Check warning on line 336 in src/components/common/Table/Table.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG0KxXVW2Rep05lu7&open=AZ3UG0KxXVW2Rep05lu7&pullRequest=27783

Check warning on line 223 in src/components/OntologyExplorer/utils/graphStyles.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Use the "RegExp.exec()" method instead. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG4muXVW2Rep05l2w&open=AZ3UG4muXVW2Rep05l2w&pullRequest=27783

Check warning on line 40 in src/components/Learning/ResourcePlayer/StorylaneTour.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'frameBorder' is deprecated. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG32lXVW2Rep05l1f&open=AZ3UG32lXVW2Rep05l1f&pullRequest=27783

Check failure on line 41 in src/components/BlockEditor/Extensions/diff-view.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `.dataset` over `getAttribute(…)`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UGzhOXVW2Rep05luA&open=AZ3UGzhOXVW2Rep05luA&pullRequest=27783

Check warning on line 189 in src/components/DataMarketplace/MarketplaceSearchBar/MarketplaceSearchBar.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Use <input type="button">, <input type="image">, <input type="reset">, <input type="submit">, or <button> instead of the "button" role to ensure accessibility across all devices. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG5BBXVW2Rep05l3r&open=AZ3UG5BBXVW2Rep05l3r&pullRequest=27783

Check failure on line 436 in src/pages/ColumnBulkOperations/ColumnGrid/hooks/useColumnGridListingData.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 21 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG5moXVW2Rep05l4y&open=AZ3UG5moXVW2Rep05l4y&pullRequest=27783

Check failure on line 925 in src/components/OntologyExplorer/hooks/useOntologyExplorer.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Refactor this code to not nest functions more than 4 levels deep. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG4ywXVW2Rep05l3R&open=AZ3UG4ywXVW2Rep05l3R&pullRequest=27783

Check warning on line 251 in src/components/common/AsyncSelectList/AsyncSelectList.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG03eXVW2Rep05lwf&open=AZ3UG03eXVW2Rep05lwf&pullRequest=27783

Check warning on line 77 in src/components/ActivityFeed/TaskFeedCard/TaskFeedCardNew.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'isFeedWidget' PropType is defined but prop is never used 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG2PSXVW2Rep05lyn&open=AZ3UG2PSXVW2Rep05lyn&pullRequest=27783

Check warning on line 415 in src/components/OntologyExplorer/hooks/useOntologyGraph.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

The empty object is useless. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG4vEXVW2Rep05l2_&open=AZ3UG4vEXVW2Rep05l2_&pullRequest=27783

Check warning on line 490 in src/components/ExploreV1/ExploreV1.component.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer using nullish coalescing operator (`??`) instead of a ternary expression, as it is simpler to read. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG435XVW2Rep05l3d&open=AZ3UG435XVW2Rep05l3d&pullRequest=27783

Check warning on line 153 in src/utils/DataContract/DataContractUtils.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG6NIXVW2Rep05l6G&open=AZ3UG6NIXVW2Rep05l6G&pullRequest=27783

Check warning on line 259 in src/components/Explore/ExploreTree/ExploreTree.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

'expanded' PropType is defined but prop is never used 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG3b9XVW2Rep05l01&open=AZ3UG3b9XVW2Rep05l01&pullRequest=27783

Check warning on line 108 in src/pages/OmHealth/OmHealthPage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG53vXVW2Rep05l5c&open=AZ3UG53vXVW2Rep05l5c&pullRequest=27783

Check warning on line 89 in src/hooks/useClipBoard.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / [open-metadata-ui] SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=open-metadata-ui&issues=AZ3UG7h1XVW2Rep05l9t&open=AZ3UG7h1XVW2Rep05l9t&pullRequest=27783
View more details on SonarQubeCloud