Skip to content

test(glossary): fix flaky "Add and Remove Assets" by using edit-button #27708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siddhant1 wants to merge 1 commit into from
Closed

test(glossary): fix flaky "Add and Remove Assets" by using edit-button #27708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Glossary.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,6 @@ test.describe('Glossary tests', () => {
const glossary1 = new Glossary();
const glossaryTerm1 = new GlossaryTerm(glossary1);
const glossaryTerm2 = new GlossaryTerm(glossary1);
glossary1.data.mutuallyExclusive = true;
glossary1.data.terms = [glossaryTerm1, glossaryTerm2];

const glossary2 = new Glossary();
Expand Down Expand Up @@ -576,9 +575,8 @@ test.describe('Glossary tests', () => {
await page.getByTestId('saveAssociatedTag').click();
await patchRequest;

// Add non mutually exclusive tags
await page.click(
'[data-testid="KnowledgePanel.GlossaryTerms"] [data-testid="glossary-container"] [data-testid="add-tag"]'
'[data-testid="KnowledgePanel.GlossaryTerms"] [data-testid="glossary-container"] [data-testid="edit-button"]'
);

// Select 1st term
Expand Down Expand Up @@ -648,7 +646,7 @@ test.describe('Glossary tests', () => {
'[data-testid="KnowledgePanel.GlossaryTerms"] [data-testid="glossary-container"] [data-testid="glossary-icon"]'
);

expect(await icons.count()).toBe(2);
expect(await icons.count()).toBe(4);
Comment thread
siddhant1 marked this conversation as resolved.

// Add Glossary to Dashboard Charts
await page.click(
Expand Down
Loading