Skip to content

Fix(ui): Added SSRS logo and md file#27656

Merged
akashverma0786 merged 2 commits intomainfrom
ssrs-logo
Apr 23, 2026
Merged

Fix(ui): Added SSRS logo and md file#27656
akashverma0786 merged 2 commits intomainfrom
ssrs-logo

Conversation

@akashverma0786
Copy link
Copy Markdown
Collaborator

@akashverma0786 akashverma0786 commented Apr 23, 2026

Screenshot 2026-04-23 at 12 22 13 Screenshot 2026-04-23 at 12 22 45

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • UI updates:
    • Integrated SSRS logo into ServiceIconUtils.ts to support rendering in the dashboard services list.
  • Documentation:
    • Added Ssrs.md providing connection requirements and configuration details for the SSRS connector.

This will update automatically on new commits.

@akashverma0786 akashverma0786 self-assigned this Apr 23, 2026
@akashverma0786 akashverma0786 requested a review from a team as a code owner April 23, 2026 07:07
@akashverma0786 akashverma0786 added the safe to test Add this label to run secure Github workflows on PRs label Apr 23, 2026
@akashverma0786 akashverma0786 enabled auto-merge (squash) April 23, 2026 07:09
@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.01% (60372/97353) 42% (31636/75306) 45% (9502/21111)

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Integrates the SSRS logo and documentation, resolving the unclosed tag for the "Host and Port" section. No further issues found.

✅ 1 resolved
Bug: Unclosed $$section tag for "Host and Port" in Ssrs.md

📄 openmetadata-ui/src/main/resources/ui/public/locales/en-US/Dashboard/Ssrs.md:17-22
The $$section opened at line 17 for "Host and Port" is never closed with a $$ tag before the next $$section starts at line 22. Every other $$section in this file (and in other Dashboard markdown files like Superset.md) is properly closed. This will likely cause rendering issues in the UI, with the "Host and Port" section swallowing subsequent sections.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (13 flaky)

✅ 3698 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 481 0 0 4
🟡 Shard 2 653 0 3 7
🟡 Shard 3 663 0 3 1
🟡 Shard 4 647 0 1 27
🟡 Shard 5 610 0 1 42
🟡 Shard 6 644 0 5 8
🟡 13 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/ColumnBulkOperations.spec.ts › should update display name and propagate to all occurrences (shard 2, 1 retry)
  • Features/DataQuality/TestLibrary.spec.ts › should handle external test definitions with read-only fields (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Flow/SchemaTable.spec.ts › schema table test (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Glossary Term Update in Glossary Page should persist tree (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for topic -> searchIndex (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@akashverma0786 akashverma0786 merged commit 458fb49 into main Apr 23, 2026
46 checks passed
@akashverma0786 akashverma0786 deleted the ssrs-logo branch April 23, 2026 10:02
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
Co-authored-by: Akash Verma <akashverma@Akashs-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants