Skip to content

test: restore OntologyExplorer entry in sidebar#27654

Merged
siddhant1 merged 1 commit into1.13from
sidebar-ontology
Apr 23, 2026
Merged

test: restore OntologyExplorer entry in sidebar#27654
siddhant1 merged 1 commit into1.13from
sidebar-ontology

Conversation

@anuj-kumary
Copy link
Copy Markdown
Member

Describe your changes:

Problem

Fixed test timeouts in Ontology Explorer by resolving missing sidebar mapping

All OntologyExplorer Playwright tests were timing out because sidebar could never find ontology explorer element. The sidebarClick utility looks up SIDEBAR_LIST_ITEMS to first expand the parent section (Governance) before clicking the child item but ONTOLOGY_EXPLORER had no entry in that map, so the parent was never expanded.

This issue is specific to v1.13; tests pass on main where the mapping exists, but it is missing in the release branch

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@anuj-kumary anuj-kumary self-assigned this Apr 23, 2026
@anuj-kumary anuj-kumary requested a review from a team as a code owner April 23, 2026 07:01
@anuj-kumary anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Apr 23, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved

Restores the OntologyExplorer entry in the sidebar. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@siddhant1 siddhant1 merged commit 6bcb5f8 into 1.13 Apr 23, 2026
33 of 65 checks passed
@siddhant1 siddhant1 deleted the sidebar-ontology branch April 23, 2026 07:09
@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.28% (59405/93872) 43.51% (31450/72271) 46.47% (9441/20316)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 6 failure(s), 19 flaky

✅ 3631 passed · ❌ 6 failed · 🟡 19 flaky · ⏭️ 99 skipped

Shard Passed Failed Flaky Skipped
🔴 Shard 1 479 1 1 4
🔴 Shard 2 643 2 2 7
🔴 Shard 3 645 1 7 6
🟡 Shard 4 619 0 3 27
🟡 Shard 5 617 0 1 42
🔴 Shard 6 628 2 5 13

Genuine Failures (failed on all attempts)

Pages/SearchIndexApplication.spec.ts › Search Index Application (shard 1)
Error: �[2mexpect(�[22m�[31mreceived�[39m�[2m).�[22mtoEqual�[2m(�[22m�[32mexpected�[39m�[2m) // deep equality�[22m

Expected: �[32mStringMatching /success|activeError/g�[39m
Received: �[31m"failed"�[39m
Features/Glossary/GlossaryAdvancedOperations.spec.ts › should remove related term (shard 2)
TypeError: Cannot read properties of undefined (reading 'unicode')
Features/Glossary/GlossaryAdvancedOperations.spec.ts › should show bidirectional related term link (shard 2)
TypeError: Cannot read properties of undefined (reading 'unicode')
Features/SettingsNavigationPage.spec.ts › should update navigation sidebar (shard 3)
Error: locator.click: Error: strict mode violation: locator('.ant-tree-title:has-text("Explore")').locator('.ant-switch') resolved to 2 elements:
    1) <button type="button" role="switch" aria-checked="true" class="ant-switch ant-switch-checked" data-testid="navigation-switch-/explore">…</button> aka getByTestId('navigation-switch-/explore')
    2) <button type="button" role="switch" aria-checked="true" class="ant-switch ant-switch-checked" data-testid="navigation-switch-/governance/ontology">…</button> aka getByTestId('navigation-switch-/governance/ontology')

Call log:
�[2m  - waiting for locator('.ant-tree-title:has-text("Explore")').locator('.ant-switch')�[22m

Pages/Glossary.spec.ts › Create term with related terms, tags and owners during creation (shard 6)
Error: �[2mexpect(�[22m�[31mreceived�[39m�[2m).�[22mtoContain�[2m(�[22m�[32mexpected�[39m�[2m) // indexOf�[22m

Expected value: �[32m"\"PW%'c871566b.Cleverdc2016c8\".\"PW.657c5b14%Giraffe864500f1\""�[39m
Received array: �[31m[undefined]�[39m
VersionPages/GlossaryVersionPage.spec.ts › GlossaryTerm (shard 6)
TypeError: Cannot read properties of undefined (reading 'displayName')
🟡 19 flaky test(s) (passed on retry)
  • Pages/Customproperties-part1.spec.ts › no duplicate card after update (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/ChangeSummaryBadge.spec.ts › AI badge should NOT appear for manually-edited descriptions (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Table.spec.ts › Tags term should be consistent for search (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Api Collection (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with assets (tables, topics, dashboards) preserves associations (shard 4, 1 retry)
  • Pages/EntityDataSteward.spec.ts › User as Owner Add, Update and Remove (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Spreadsheet (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Inactive Announcement create & delete (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants