Skip to content

test: fix race condition for upload files #27650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddhant1 merged 3 commits into from
Apr 23, 2026
+17 −10
Merged

test: fix race condition for upload files #27650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0dcf758
test: resolve flaky CSVImportWithQuotesAndCommas test due to timeout …
anuj-kumary Apr 23, 2026
671f12d
fix lint issue
anuj-kumary Apr 23, 2026
5729343
Merge branch 'main' into csv-import-test
anuj-kumary Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/importUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,9 +538,13 @@ export const uploadCSVAndWaitForGrid = async (
}

await page.setInputFiles('[type="file"]', actualFilePath);
await page.getByTestId('upload-file-widget').waitFor({ state: 'hidden' });
await page
.getByTestId('upload-file-widget')
.waitFor({ state: 'hidden', timeout: 30000 });

await expect(page.locator('.rdg-header-row')).toBeVisible();
await page
.locator('.rdg-header-row')
.waitFor({ state: 'visible', timeout: 30000 });
const rowCount = await page.locator('.rdg-row').count();
return { rowCount, tempFilePath };
};
Expand Down
19 changes: 11 additions & 8 deletions openmetadata-ui/src/main/resources/ui/src/components/UploadFile/UploadFile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,23 @@ const UploadFile: FC<UploadFileProps> = ({
const handleUpload: UploadProps['customRequest'] = useCallback(
(options: UploadRequestOption) => {
setUploading(true);
const reader = new FileReader();
reader.onload = (e) => {
setUploading(false);
onCSVUploaded(e);
};
reader.onerror = () => {
setUploading(false);
showErrorToast(new Error(t('server.unexpected-error')) as AxiosError);
};
try {
const reader = new FileReader();
reader.onload = onCSVUploaded;
reader.onerror = () => {
throw t('server.unexpected-error');
};
reader.readAsText(options.file as Blob);
} catch (error) {
showErrorToast(error as AxiosError);
} finally {
setUploading(false);
showErrorToast(error as AxiosError);
}
},
[onCSVUploaded]
[onCSVUploaded, t]
);

return uploading ? (
Expand Down
Loading