-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(advanced-search): move entityStatus to common config with hard-coded list values #27642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8ad568b
fix(advanced-search): move entityStatus to common config with hard-co…
Rohit0301 e7bf702
Merge branch 'main' into fix-27570
Rohit0301 b80b63a
lint and unit test fix
Rohit0301 053d337
Merge branch 'main' into fix-27570
Rohit0301 d168c15
Merge branch 'main' into fix-27570
Rohit0301 a8f2d30
Merge branch 'main' into fix-27570
Rohit0301 524331a
addressed PR comment
Rohit0301 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Bug: Dropped '@advanced-search' tag from Entity Status test describe
The original code tagged this
test.describewith both['@advanced-search', '@Discovery']. The refactor replaced it with[DOMAIN_TAGS.DISCOVERY]which only resolves to'@Discovery', dropping the@advanced-searchtag.The main
test.describe('Advanced Search', ...)block at line 52 uses{ tag: ['@advanced-search'] }. If CI or local test runs use--grep @advanced-searchto run all advanced-search tests, this nested describe block will no longer be selected.This may be intentional (aligning with a tag convention migration), but if not, the Entity Status filter tests will silently stop running in
@advanced-search-filtered test suites.Suggested fix:
Was this helpful? React with 👍 / 👎 | Reply
gitar fixto apply this suggestion