add https support for Druid connector#27634
add https support for Druid connector#27634Nitin2332 wants to merge 2 commits intoopen-metadata:mainfrom
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ Approved 1 resolved / 1 findingsDruid connector now supports HTTPS connections. The previously identified lack of unit testing for the new connection logic has been resolved. ✅ 1 resolved✅ Quality: New HTTPS connection logic in get_connection() is untested
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Describe your changes:
Fixes #25991
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
druid+httpsoption todruidSchemeindruidConnection.json.connection.pyto setuse_httpsin connection arguments whendruid+httpsscheme is selected.test_source_connection.pyto verify HTTPS connection URL generation.Druid.mdto provide instructions on usingdruid+httpsfor HTTPS connections.This will update automatically on new commits.