collections: smoother search clearing (fixes #10366) - #10367
Open
RyanS4 wants to merge 1 commit into
Open
Conversation
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You鈥檝e used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: 鈿欙笍 Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 馃搾 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10366
Problem
PlanetTagInputDialogComponent), the Filter by Collection Name input lacked an in-box clear (X) button, requiring users to manually select and backspace search text.Proposed Solution
matSuffixbutton with acloseicon to the collection filter form field inplanet-tag-input-dialog.component.html.updateFilter(''), clearing the input and resetting the displayed collection list.[style.visibility]="filterValue ? 'visible' : 'hidden'"along with localized tooltip and accessiblearia-label.MatSuffixandMatIconButtoninPlanetTagInputDialogComponent.imports.Verification
npm run lintpassed with 0 errors.npx vitest runpassed (279/279 tests).