Skip to content

collections: smoother search clearing (fixes #10366) - #10367

Open
RyanS4 wants to merge 1 commit into
masterfrom
10366-collections-search-upgrade
Open

collections: smoother search clearing (fixes #10366)#10367
RyanS4 wants to merge 1 commit into
masterfrom
10366-collections-search-upgrade

Conversation

@RyanS4

@RyanS4 RyanS4 commented Aug 31, 2026

Copy link
Copy Markdown
Member

Fixes #10366

Problem

  • In the Collections modal dialog (PlanetTagInputDialogComponent), the Filter by Collection Name input lacked an in-box clear (X) button, requiring users to manually select and backspace search text.
  • This was inconsistent with all other recently upgraded search and filter bars across Planet.

Proposed Solution

  • Added an in-box matSuffix button with a close icon to the collection filter form field in planet-tag-input-dialog.component.html.
  • Bound the button click to updateFilter(''), clearing the input and resetting the displayed collection list.
  • Added conditional visibility [style.visibility]="filterValue ? 'visible' : 'hidden'" along with localized tooltip and accessible aria-label.
  • Registered MatSuffix and MatIconButton in PlanetTagInputDialogComponent.imports.

Verification

  • Lint: npm run lint passed with 0 errors.
  • Unit Tests: npx vitest run passed (279/279 tests).
image

@RyanS4 RyanS4 added the review label Aug 31, 2026
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 57 minutes.

View limit details

Limit details: You鈥檝e used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

鈿欙笍 Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f80766b6-215c-4bb5-9b40-e874c0612209

馃摜 Commits

Reviewing files that changed from the base of the PR and between 15e1efe and c1897fb.

馃搾 Files selected for processing (2)
  • src/app/shared/forms/planet-tag-input-dialog.component.html
  • src/app/shared/forms/planet-tag-input-dialog.component.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collections: upgrade search clear

1 participant