Skip to content

fix(otel)!: bump opentelemetry-semconv-incubating to 1.43.0-alpha - #1844

Open
bye-rez wants to merge 1 commit into
open-feature:mainfrom
bye-rez:fix/otel-semconv-provider-name-bump
Open

fix(otel)!: bump opentelemetry-semconv-incubating to 1.43.0-alpha#1844
bye-rez wants to merge 1 commit into
open-feature:mainfrom
bye-rez:fix/otel-semconv-provider-name-bump

Conversation

@bye-rez

@bye-rez bye-rez commented Aug 26, 2026

Copy link
Copy Markdown

This PR

Bumps opentelemetry-semconv-incubating to 1.43.0-alpha in hooks/open-telemetry and updates the one hardcoded test assertion that relied on the old attribute string.

Related Issues

Relates to #1843

Notes

This version renames the feature_flag.provider_name span attribute to feature_flag.provider.name (underscore → dot). Our hook code references the FEATURE_FLAG_PROVIDER_NAME constant rather than a literal, so no source change is needed — only TracesHookTest.java's hardcoded assertion string is updated to match.

Breaking change: consumers reading the feature_flag.provider_name span attribute (dashboards, alerts, queries) will need to update to feature_flag.provider.name.

Follow-up Tasks

A separate PR will adopt newly available semconv attributes (e.g. FEATURE_FLAG_RESULT_VARIANT) — intentionally not bundled here.

How to test

./mvnw --projects hooks/open-telemetry --also-make clean verify

opentelemetry-semconv-incubating 1.43.0-alpha renames the
feature_flag.provider_name span attribute to feature_flag.provider.name.
FEATURE_FLAG_PROVIDER_NAME is referenced by constant in OTelCommons.java,
so no source change is needed there; only the hardcoded assertion string
in TracesHookTest.java is updated to match.

BREAKING CHANGE: consumers reading the feature_flag.provider_name span
attribute (dashboards, alerts, queries) must update to
feature_flag.provider.name.

Signed-off-by: Alex Bairez <bairez14@icloud.com>
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 15edcb64-14d1-48a4-a230-33d959722944

📥 Commits

Reviewing files that changed from the base of the PR and between d69584b and bd9d1d2.

📒 Files selected for processing (2)
  • hooks/open-telemetry/pom.xml
  • hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/TracesHookTest.java

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The OpenTelemetry semantic conventions dependency was upgraded from 1.28.0-alpha to 1.43.0-alpha. The trace hook test now expects the feature_flag.provider.name attribute key.

Changes

OpenTelemetry semantic conventions

Layer / File(s) Summary
Dependency and test alignment
hooks/open-telemetry/pom.xml, hooks/open-telemetry/src/test/.../TracesHookTest.java
The incubating semantic conventions dependency was upgraded. The provider-name test attribute key was updated to feature_flag.provider.name.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bd9d1

This PR updates the OpenTelemetry semantic-convention dependency and its matching test assertion; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: aepfli, chrfwow, justinabrahms, toddbaert

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the OpenTelemetry semantic-conventions dependency bump to version 1.43.0-alpha. The breaking-change marker is consistent with the renamed span attribute.
Description check ✅ Passed The description accurately covers the dependency update, test assertion change, renamed attribute, consumer impact, deferred work, and test command.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants