fix(otel)!: bump opentelemetry-semconv-incubating to 1.43.0-alpha - #1844
fix(otel)!: bump opentelemetry-semconv-incubating to 1.43.0-alpha#1844bye-rez wants to merge 1 commit into
Conversation
opentelemetry-semconv-incubating 1.43.0-alpha renames the feature_flag.provider_name span attribute to feature_flag.provider.name. FEATURE_FLAG_PROVIDER_NAME is referenced by constant in OTelCommons.java, so no source change is needed there; only the hardcoded assertion string in TracesHookTest.java is updated to match. BREAKING CHANGE: consumers reading the feature_flag.provider_name span attribute (dashboards, alerts, queries) must update to feature_flag.provider.name. Signed-off-by: Alex Bairez <bairez14@icloud.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe OpenTelemetry semantic conventions dependency was upgraded from ChangesOpenTelemetry semantic conventions
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR updates the OpenTelemetry semantic-convention dependency and its matching test assertion; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR
Bumps
opentelemetry-semconv-incubatingto1.43.0-alphainhooks/open-telemetryand updates the one hardcoded test assertion that relied on the old attribute string.Related Issues
Relates to #1843
Notes
This version renames the
feature_flag.provider_namespan attribute tofeature_flag.provider.name(underscore → dot). Our hook code references theFEATURE_FLAG_PROVIDER_NAMEconstant rather than a literal, so no source change is needed — onlyTracesHookTest.java's hardcoded assertion string is updated to match.Breaking change: consumers reading the
feature_flag.provider_namespan attribute (dashboards, alerts, queries) will need to update tofeature_flag.provider.name.Follow-up Tasks
A separate PR will adopt newly available semconv attributes (e.g.
FEATURE_FLAG_RESULT_VARIANT) — intentionally not bundled here.How to test