Skip to content

Stop-signal tutorial#105

Open
brokulek26 wants to merge 4 commits into
open-cogsci:4.1from
brokulek26:4.1
Open

Stop-signal tutorial#105
brokulek26 wants to merge 4 commits into
open-cogsci:4.1from
brokulek26:4.1

Conversation

@brokulek26
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@smathot smathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two figures are missing, but other than that it seems to work fine. If you add these to the PR, I'll polish the tutorial a bit and then merge it. (Unless I run into other things.) Thanks! 🙏

%--
figure:
id: Fig_paradigm
source: stop_paradigm.png
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stop_paradigm.pnd is missing from the commit.

%--
figure:
id: Fig_logger
source: stop_logger.png
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing

@smathot
Copy link
Copy Markdown
Collaborator

smathot commented Apr 22, 2026

Thanks! I went through the tutorial in a bit more detail. It's very nicely done, but there are some things that will likely be bit confusing for the user.

Right now Figure 2 already shows the trial sequence with the coroutines and all the items inside. This implies that it this point this has already been done, but it hasn't – only in step 4 are the items created. This step states that these items need to be created before creating the coroutines item itself, but that's not necessary. You can simply first create a coroutines item and then add items to it, just like you would with a sequence. The order of steps is the same in other words.

Bottom line: the tutorial should show things in the natural order, so first an empty trial sequence, then add a coroutines, then add items to the coroutines, and then configure the start time, run-if, etc. of these items inside the coroutines.

Step 6.6 emphasizes that the sampler should have a 0 duration. But that's actually not applicable, because the duration is controlled by the coroutines item.

Connected to the point above, the fact that when using coroutines, many of the duration options of items suddenly become ineffective and are instead controlled at the level of the coroutines is something that many users will find confusing (and is indeed not ideal from a usability perspective). You already mention this, but I think it warrants a bit more emphasis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants