Conversation
`install.sh` has nothing to do with the browser client. It lived in `web/public/` only because entry 8's split deployment served it as a static file. The release workflow publishes it from that path under `fail_on_unmatched_files`, so deleting `web/` first would fail the next tag in `publish`, after the whole build matrix had already succeeded. Moving it first keeps the release path intact through every commit of the removal. The relay's `/install.sh` route goes too. It served the file so a curl against the hosted relay worked, and entry 16 removed that host. The README already points at the release asset. The script is byte-identical to the v0.3.0 release asset, and `DROP_VERSION=v0.3.0` installs a binary that reports 0.3.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser client removal, phase 0. It changes the release workflow, so it needs your review before merging. Stacked on #65.
Why this goes first, on its own
release.ymlsparse-checks-outweb/public/install.shand publishes it withfail_on_unmatched_files: true. Ifweb/were deleted first, the nextv*tag would fail in thepublishjob, after the full build matrix had already succeeded. The oldchore/remove-webbranch does exactly that.Changes
web/public/install.shmoves toscripts/install.sh. Mode100755is kept and the content is unchanged.release.ymlpoints its sparse checkout, comment andfiles:entry atscripts/install.sh./install.shroute is removed. It existed so a curl against the hosted relay worked, and that host is gone (decision 16). The README already uses the GitHub release asset.docs/deployment.mdno longer says a deployment serves the installer.Verified
scripts/install.shis byte-identical to the v0.3.0 release asset (cmpagainst the download).DROP_VERSION=v0.3.0 DROP_INSTALL_DIR=<scratch> sh scripts/install.shinstalls a binary that printsdrop 0.3.0.cargo fmt --check,cargo clippy -D warningsandcargo test --workspace --all-targetspass. 180 tests, the same count as before, since no test covered the route.scripts/check-secrets.shpasses.Not verifiable without tagging: the publish job itself. Checked by reading instead: no
web/publicreference remains inrelease.yml.🤖 Generated with Claude Code
https://claude.ai/code/session_01G7Fy45hUvna94cd79WKG8S