Input: re-lift opt-in SP11 pen userspace interfaces - #34
Merged
Conversation
If connecting a hid_device with bus field indicating BUS_SPI print out "SPI" in the debug print. Macro sets the bus field to BUS_SPI and uses arguments to set vendor product fields. [Leon: mirror BUS_SPI in the HID-BPF helper enum used by this tree.] Link: https://patchew.org/linux/20260609-send-upstream-v4-0-b843d5e6ced3@chromium.org/20260609-send-upstream-v4-2-b843d5e6ced3@chromium.org/ Link: 61bb237 Signed-off-by: Dmitry Antipov <dmanti@microsoft.com> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Jingyuan Liang <jingyliang@chromium.org> Signed-off-by: Leon Silcott <leon@boasi.io>
Rework the Surface Pro 11 pen support behind two independent, default-off feature gates. The heat-frame option builds the versioned misc-device ABI, while the iptsd option builds the HIDRAW sibling and native pen input path. Require a matching device-tree property at probe time for each option before its endpoint can be registered. With both options disabled, retain the existing touch initialization, falling-edge IRQ handling, and input path. Keep the validated IPTS initialization and level-low IRQ cadence confined to the iptsd opt-in. Use the controller driver's existing HID-over-SPI transactions and only add the HID core support needed for the private BUS_SPI child; do not carry the generic SPI-HID transport. Link: b805934 Link: c575142 Link: 71e31fa Link: dc4f260 Link: f1b743c Link: f831b6c Link: c05ed50 Link: 133679a Link: e417f2f Signed-off-by: Leon Silcott <leon@boasi.io>
Opt both Surface Pro 11 variants into the optional raw heat-frame ABI and HIDRAW iptsd bridge. The matching default-off kernel options must still be enabled before either interface is built, while machines outside the shared Denali DTSI remain unchanged. Link: 71e31fa Link: dc4f260 Signed-off-by: Leon Silcott <leon@boasi.io>
Record the two opt-in MSHW0485 feature gates in the qcom-x1e annotations. Kconfig still defaults both options to n; this Ubuntu flavour explicitly enables them for Denali, whose device tree must also opt in before either endpoint registers. Link: 4c2356a Depends-on: jglathe#83 Signed-off-by: Leon Silcott <leon@boasi.io>
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lift the opt-in MSHW0485 heat-frame and HIDRAW iptsd interfaces from upstream-review PR jglathe#84 after the guarded direct-touch prerequisite.
Containment
CONFIG_*optionsProvenance
Jarrett Schultz remains author of the generic HID SPI bus definition. The binding, driver containment, Denali opt-in, and Ubuntu configuration commits retain Leon Silcott as author. Full audit history is in jglathe#84.
Validation
git diff --check: passPen hover, pressure, tilt, buttons, concurrent touch, recovery, and X1P parity require testing from the complete beta build.