Skip to content

ci: publish previews without waiting for tests - #477

Merged
vite-hub[bot] merged 2 commits into
mainfrom
ci/publish-without-tests
Nov 21, 2026
Merged

vite-hub[bot] merged 2 commits into
mainfrom
ci/publish-without-tests

Conversation

@onmax

@onmax onmax commented Nov 21, 2026

Copy link
Copy Markdown
Owner

The pkg.pr.new preview showed up only after the slowest CI job finished. publish had needs: check, which is the whole ci.yml call, so it waited for e2e, where installing WebKit has taken up to about 980 s, and for the test suite in the check job.

needs on a reusable workflow call waits for every job in it, so it can't point at build alone. This PR has publish run pnpm build (which fails on publint through tsdown.shared.ts) and pnpm check itself, then publish, next to CI. A broken build or a failing check still publishes nothing. ci.yml is unchanged: tests, doctor, docs and e2e still run there; they just no longer hold the preview back. The publish job now builds the packages a second time, which costs about a minute or two of runner time. That's an estimate, I haven't timed it yet.

Validation: actionlint passes on the workflow. The preview job on this PR is the real check.

🤖 Generated with Claude Code

The publish job waited for the whole CI run. It now builds and checks
the packages itself and runs next to the tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-21T10:26:56.905076Z
We couldn’t complete this review. Comment @codex review to try again.
d657a04 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

The standalone preview job currently fails its typecheck and skips publishing.

Approach: Running the preview build and checks alongside full CI removes the test bottleneck, but the standalone job must also generate the Nuxt types that pnpm check needs.

Reviewed changes — I traced the new preview job against the reusable CI workflow and checked the failed GitHub Actions run.

  • Preview publishing: Builds and checks packages locally instead of waiting for full CI and downloading its build artifact.
  • CI and permissions: Leaves full CI running independently and keeps publishing restricted to same-repository PRs and release-branch pushes.

Pullfrog  | Fix all ➔ | Fix 👍s ➔ | View workflow run | Using gpt-6.2-sol(high) | 𝕏

Comment thread .github/workflows/pkg-pr-new.yml Resolved
@vite-hub

vite-hub Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —
View session Completed 2026-11-21T11:35:09.636Z 3m 23s
View session Completed 2026-11-21T11:14:57.079Z 13m 1s

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

View session

PR #477 is ready to merge. The preview job generates Nuxt configs after building and passes its checks before publishing, without waiting for the test jobs. GitHub Actions passed and pkg.pr.new published the preview for fad8371. The prior P1 thread is resolved, and no further changes were needed.

View session

Pushed fad8371 to fix the P1 preview failure: the publish job now generates Nuxt configs after building and before `pnpm check`, without waiting for tests. Resolved the review thread. The package build and lint passed locally, and Nuxt generated all four configs. A Kroki fetch failure blocked the full local docs typecheck, so hosted CI will verify the preview job.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found. No P0 or P1 findings remain.

Reviewed changes — I verified the step order in fad8371 against the docs preparation and typecheck scripts.

  • Generated Nuxt types before checking. The preview job now runs the docs prepare script after pnpm build creates the files it needs and before pnpm check reads the generated Nuxt configs. The preview job was still running at review time.

Pullfrog  | View workflow run | Using gpt-6.2-sol(high) | 𝕏

@pkg-pr-new

pkg-pr-new Bot commented Nov 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark-annotate

pnpm add https://pkg.pr.new/comark-annotate@477

comark-badge

pnpm add https://pkg.pr.new/comark-badge@477

comark-bundle

pnpm add https://pkg.pr.new/comark-bundle@477

comark-cards

pnpm add https://pkg.pr.new/comark-cards@477

comark-carousel

pnpm add https://pkg.pr.new/comark-carousel@477

comark-cast

pnpm add https://pkg.pr.new/comark-cast@477

comark-charts

pnpm add https://pkg.pr.new/comark-charts@477

comark-chat

pnpm add https://pkg.pr.new/comark-chat@477

comark-chips

pnpm add https://pkg.pr.new/comark-chips@477

comark-cjk

pnpm add https://pkg.pr.new/comark-cjk@477

comark-code

pnpm add https://pkg.pr.new/comark-code@477

comark-code-notes

pnpm add https://pkg.pr.new/comark-code-notes@477

comark-colors

pnpm add https://pkg.pr.new/comark-colors@477

comark-comments

pnpm add https://pkg.pr.new/comark-comments@477

comark-critic

pnpm add https://pkg.pr.new/comark-critic@477

comark-deflist

pnpm add https://pkg.pr.new/comark-deflist@477

comark-details

pnpm add https://pkg.pr.new/comark-details@477

comark-diagrams

pnpm add https://pkg.pr.new/comark-diagrams@477

comark-diff

pnpm add https://pkg.pr.new/comark-diff@477

comark-embed

pnpm add https://pkg.pr.new/comark-embed@477

comark-fields

pnpm add https://pkg.pr.new/comark-fields@477

comark-figure

pnpm add https://pkg.pr.new/comark-figure@477

comark-file-tree

pnpm add https://pkg.pr.new/comark-file-tree@477

comark-footnotes

pnpm add https://pkg.pr.new/comark-footnotes@477

comark-git-graph

pnpm add https://pkg.pr.new/comark-git-graph@477

comark-github

pnpm add https://pkg.pr.new/comark-github@477

comark-icon

pnpm add https://pkg.pr.new/comark-icon@477

comark-include

pnpm add https://pkg.pr.new/comark-include@477

comark-keys

pnpm add https://pkg.pr.new/comark-keys@477

comark-links

pnpm add https://pkg.pr.new/comark-links@477

comark-linter

pnpm add https://pkg.pr.new/comark-linter@477

comark-magic-move

pnpm add https://pkg.pr.new/comark-magic-move@477

comark-mark

pnpm add https://pkg.pr.new/comark-mark@477

markdown-it-to-comark

pnpm add https://pkg.pr.new/markdown-it-to-comark@477

marked-to-comark

pnpm add https://pkg.pr.new/marked-to-comark@477

comark-mathml

pnpm add https://pkg.pr.new/comark-mathml@477

comark-media

pnpm add https://pkg.pr.new/comark-media@477

comark-metrics

pnpm add https://pkg.pr.new/comark-metrics@477

migrate-to-comark

pnpm add https://pkg.pr.new/migrate-to-comark@477

comark-motion

pnpm add https://pkg.pr.new/comark-motion@477

comark-outline

pnpm add https://pkg.pr.new/comark-outline@477

comark-properties

pnpm add https://pkg.pr.new/comark-properties@477

comark-qr

pnpm add https://pkg.pr.new/comark-qr@477

comark-quiz

pnpm add https://pkg.pr.new/comark-quiz@477

comark-reading-time

pnpm add https://pkg.pr.new/comark-reading-time@477

remark-to-comark

pnpm add https://pkg.pr.new/remark-to-comark@477

comark-sources

pnpm add https://pkg.pr.new/comark-sources@477

comark-steps

pnpm add https://pkg.pr.new/comark-steps@477

comark-table

pnpm add https://pkg.pr.new/comark-table@477

comark-tabs

pnpm add https://pkg.pr.new/comark-tabs@477

comark-tests

pnpm add https://pkg.pr.new/comark-tests@477

comark-time

pnpm add https://pkg.pr.new/comark-time@477

comark-ui

pnpm add https://pkg.pr.new/comark-ui@477

comark-xref

pnpm add https://pkg.pr.new/comark-xref@477

comark-zoom

pnpm add https://pkg.pr.new/comark-zoom@477

commit: fad8371

@vite-hub
vite-hub Bot merged commit e9bd7b3 into main Nov 21, 2026
7 checks passed
@vite-hub
vite-hub Bot deleted the ci/publish-without-tests branch November 21, 2026 11:41
@github-actions github-actions Bot mentioned this pull request Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant