Repository navigation
ci: publish previews without waiting for tests - #477
Conversation
The publish job waited for the whole CI run. It now builds and checks the packages itself and runs next to the tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Important
The standalone preview job currently fails its typecheck and skips publishing.
Approach: Running the preview build and checks alongside full CI removes the test bottleneck, but the standalone job must also generate the Nuxt types that pnpm check needs.
Reviewed changes — I traced the new preview job against the reusable CI workflow and checked the failed GitHub Actions run.
- Preview publishing: Builds and checks packages locally instead of waiting for full CI and downloading its build artifact.
- CI and permissions: Leaves full CI running independently and keeps publishing restricted to same-repository PRs and release-branch pushes.
gpt-6.2-sol(high) | 𝕏
Latest result Pull request merged. Final answersSession Pull request merged. PR #477 is ready to merge. The preview job generates Nuxt configs after building and passes its checks before publishing, without waiting for the test jobs. GitHub Actions passed and pkg.pr.new published the preview for fad8371. The prior P1 thread is resolved, and no further changes were needed. Pushed fad8371 to fix the P1 preview failure: the publish job now generates Nuxt configs after building and before `pnpm check`, without waiting for tests. Resolved the review thread. The package build and lint passed locally, and Nuxt generated all four configs. A Kroki fetch failure blocked the full local docs typecheck, so hosted CI will verify the preview job. |
There was a problem hiding this comment.
✅ No new issues found. No P0 or P1 findings remain.
Reviewed changes — I verified the step order in fad8371 against the docs preparation and typecheck scripts.
- Generated Nuxt types before checking. The preview job now runs the docs
preparescript afterpnpm buildcreates the files it needs and beforepnpm checkreads the generated Nuxt configs. The preview job was still running at review time.
gpt-6.2-sol(high) | 𝕏
comark-annotate
comark-badge
comark-bundle
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-git-graph
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-motion
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |

The pkg.pr.new preview showed up only after the slowest CI job finished.
publishhadneeds: check, which is the wholeci.ymlcall, so it waited fore2e, where installing WebKit has taken up to about 980 s, and for the test suite in thecheckjob.needson a reusable workflow call waits for every job in it, so it can't point atbuildalone. This PR haspublishrunpnpm build(which fails on publint throughtsdown.shared.ts) andpnpm checkitself, then publish, next to CI. A broken build or a failing check still publishes nothing.ci.ymlis unchanged: tests, doctor, docs and e2e still run there; they just no longer hold the preview back. The publish job now builds the packages a second time, which costs about a minute or two of runner time. That's an estimate, I haven't timed it yet.Validation:
actionlintpasses on the workflow. The preview job on this PR is the real check.🤖 Generated with Claude Code