Support multiple fee receiver accounts#100
Open
janezpodhostnik wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testnet distributes transaction fee deposits across multiple receiver accounts since the FlowFees concurrent-fee-collection upgrade (onflow/flow-core-contracts#575, rolled out in tx
be210889dd26a320f530595bd369093e866e26c3941bf7a3d01f861db3eeda81). Rosetta only recognized deposits to the FlowFees contract account as fees, so deposits to the child fee accounts were misclassified as ordinary transfers.Changes
feeAddrwith a set of fee addresses (Contracts.FeeAddresses()): the FlowFees account plus a new.contracts.fee_receiversconfig list.testnet.json(canonical list: flow-go'ssystemcontracts.FlowFeesReceivers).validateFeeReceivers) that reads the on-chain receiver list from/storage/ChildFeeAccountsvia a newget-fee-receiversscript and exits with a fatal error if any on-chain receiver is missing from the config — so future receiver additions fail loudly instead of silently misclassifying fees. Extra configured addresses are allowed (needed to classify fees in historical blocks).Mainnet & future cleanup
Mainnet has no child fee accounts yet, so
mainnet.jsonis unchanged and behavior there is identical — but the upgrade is expected to roll out there soon, at which point the startup check will flag the new receivers andmainnet.jsonjust needs afee_receiversentry. Separately, once onflow/flow-core-contracts#614 lands, the entitlement-sensitive storage read inget-fee-receivers.cdccan be replaced with a stablegetFeeReceiverAddresses()call.