[Storehouse] 009 Payloadless factory and localnet

[zhangchiqing]

The previous PR #8598 can startup a payloadless mode EN with a payloadless checkpoint file, and replay wal files to resume execution. But the localnet doesn't work, because localnet is bootstrapping with a v6 checkpoint, no v7 checkpoint. So a automatic conversion from v6 to v7 checkpoint is required during bootstrapping. And after this PR, we can startup a payloadless mode EN in localnet.

• Added Payloadless factory method
• Removed the Factory interface. Instead, inlined the ledger client creation for remote ledger service, and inlined the ledger storage creation for local ledger mode.

Summary by CodeRabbit

• New Features

  • Added payloadless ledger mode for local and remote deployments.
  • Added a payloadless option to localnet setup, including automatic execution-node and ledger configuration.
  • Startup reporting now indicates whether payloadless mode is active.
  • Localnet bootstrapping now prepares the required V7 checkpoint for payloadless operation.

• Bug Fixes

  • Remote-ledger configurations now correctly avoid unnecessary local checkpoint conversion.
  • Payloadless ledgers require a valid V7 root checkpoint before starting, preventing initialization from incomplete state.

[coderabbitai]

Important

Review skipped

The saved review history does not include the base for the last reviewed commit. This saved history cannot establish the base for an incremental review. Comment @coderabbitai full review to establish a new review baseline. No full review was started, and the last reviewed checkpoint was preserved.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The change adds payloadless ledger mode across ledger construction, service startup, WAL checkpoint handling, and localnet bootstrap. It also removes ledger factory interfaces and routes local and remote ledger creation through direct constructors.

Changes

Payloadless ledger integration

Layer / File(s)	Summary
Ledger construction dispatch ledger/factory.go, ledger/factory/factory.go, ledger/complete/factory.go, ledger/remote/factory.go, ledger/mock/factory.go, ledger/factory/factory_test.go	Factory interfaces and implementations are removed. Local and remote ledgers use direct constructors. NewPayloadlessLedger selects a local ledger or remote client from LedgerServiceAddr.
Payloadless checkpoint startup ledger/complete/wal/*, ledger/complete/payloadless_ledger_with_compactor_test.go	Payloadless startup now requires a numbered or root V7 checkpoint. WAL replay returns an error when no V7 checkpoint exists. Tests seed valid V7 roots and verify the missing-checkpoint error.
Ledger service mode selection cmd/ledger/main.go	The ledger command adds --payloadless, selects the matching ledger and gRPC service, shares lifecycle handling, and validates state through a common inspection interface.
Localnet payloadless bootstrap integration/localnet/Makefile, integration/localnet/builder/bootstrap.go, cmd/execution_builder.go	Localnet accepts and propagates payloadless mode. It converts available V6 root checkpoints to V7, creates V7 links, and avoids local conversion when a remote ledger service is configured.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant LocalnetBuilder
  participant ExecutionNode
  participant LedgerCommand
  participant LedgerFactory
  participant LedgerService
  LocalnetBuilder->>ExecutionNode: start with payloadless and storehouse flags
  LocalnetBuilder->>LedgerService: start with payloadless flag and V7 checkpoint
  LedgerCommand->>LedgerFactory: select local or remote payloadless ledger
  LedgerFactory-->>LedgerCommand: return ledger and service registration
  LedgerCommand->>LedgerService: register selected gRPC service

Loading

Suggested reviewers: janezpodhostnik

Merge Risk: 🔵 Low · up to 542c5

Remote payloadless startup is newly supported but untested; add the focused configuration test before broad reliance on this mode.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 73.68% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 8 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main changes: payloadless factory support and localnet integration.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch leo/payloadless-remote-ledger-service

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[codecov-commenter]

Codecov Report

❌ Patch coverage is 5.71429% with 165 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
ledger/mock/payloadless_ledger.go	0.00%	58 Missing ⚠️
integration/localnet/builder/bootstrap.go	0.00%	55 Missing ⚠️
cmd/ledger/main.go	0.00%	22 Missing ⚠️
ledger/factory/factory.go	31.03%	17 Missing and 3 partials ⚠️
ledger/complete/wal/wal.go	0.00%	4 Missing and 1 partial ⚠️
ledger/remote/payloadless_client.go	0.00%	4 Missing ⚠️
cmd/execution_builder.go	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!