Add CI test for crates.io setup and testing - #49
Conversation
b4f9c60 to
3dfa620
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain.
Pull request overview
Adds a GitHub Actions workflow to validate installing and running sycl-rs from crates.io with oneAPI.
Changes:
- Configures oneAPI on the self-hosted runner.
- Creates a temporary Cargo project using
sycl-rs0.1.0. - Builds and runs a SYCL platform smoke test.
File summaries
| File | Description |
|---|---|
.github/workflows/crates-io.yml |
Adds crates.io installation, build, and runtime validation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
szymon-zadworny
left a comment
szymon-zadworny
left a comment
There was a problem hiding this comment.
This check runs on each PR, but it doesn't actually check the pull request - it only checks the most recently published sycl-rs version.
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
| SYCL_RS_VERSION: 0.1.0 |
There was a problem hiding this comment.
This parameter has to be updated on each version change.
There was a problem hiding this comment.
fixed - the workflow now always tests the latest version
| run: | | ||
| cargo init --bin "$RUNNER_TEMP/crates-io-test" | ||
| cd "$RUNNER_TEMP/crates-io-test" | ||
| cargo add "sycl-rs@$SYCL_RS_VERSION" |
There was a problem hiding this comment.
This is downloading the crate from a public repository (crates.io). This CI check doesn't actually validate new pull requests - in only checks a past version published on crates.io.
We should either set the dependency as a git repository or use source replacement. We need to make sure our library compiles with standard Rust tooling as part of another project, but from that point of view it doesn't really matter whether we download our sources from crates.io or from another mirror.
There was a problem hiding this comment.
outdated, please check the latest version of changes
3dfa620 to
e7daddf
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Critical security and dependency-resolution issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Lite
|
|
||
| jobs: | ||
| build-and-test: | ||
| runs-on: ["oneapi-rs", "Linux"] |
e7daddf to
529f947
Compare
1acf729 to
2f5af0d
Compare
|
@szymon-zadworny please re-review |
Add CI tests for crates.io setup and testing:
Additionally, this PR adds badges for all scheduled tests and the latest main.