Fix data course ID normalization#15
Open
tran-christian wants to merge 3 commits into
Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
static/courses.jsonbefore falling back to section-specific special-topic IDs.MGT-8813/ Financial Modeling, while keeping true section-coded courses likeCS-8803-O31.data/catalog.json, andstatic/courses.jsonso all live OMSCS current-courses entries are represented.Root Cause
The OSCAR parser treated every
8803,8813, and8823section as section-specific. That made Banner rows such asMGT 8813 O01becomeMGT-8813-O01, which did not join with the canonicalMGT-8813static catalog entry and could degrade the displayed name toSpecial Topics.Validation
node --import tsx --test oscar/parser.test.tspage count 75,missing static 0,missing data catalog 0MGT-8813shows oneFinancial Modelingrow, and no staleMGT-8813-O01row appears.