Skip to content

PTD-23.1.8: Preserve portable Python compatibility in final images - #155

Merged
omry merged 1 commit into
pr154from
pr155
Sep 15, 2026
Merged

omry merged 1 commit into
pr154from
pr155

Conversation

@omry

@omry omry commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Require final-image validation to preserve the locked portable Python interpreter and wheel-tag facts. Keep ordinary Python profiles on their existing compatible-version policy, with focused drift coverage for every portable fact.
@omry
omry changed the base branch from main to pr154 September 15, 2026 15:00
@omry
omry added this pull request to stack #151 September 15, 2026 15:00
@gitar-bot

gitar-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds final-image validation to preserve locked portable Python interpreter and wheel-tag facts while keeping ordinary Python profiles on their existing compatible-version policy. No issues found.

Review coverage

Rules No rules evaluated

Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Sep 15, 2026

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:2290d7486eb6ab89996f77d2c289d90798c5f3f4fe11dbe676bda4788b5c8637",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:2290d7486eb6ab89996f77d2c289d90798c5f3f4fe11dbe676bda4788b5c8637",
      "check_conclusions": [],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:fbfc03ddebcd54bafce739fae177e06fc072694063a794f67f950be120529559",
      "review_request": {
        "body_digest": "sha256:bf4600a343331e791ced03aa158cd5c2fa6eef66bb9f6c6d2f6f65783fe1842b",
        "id": 5682713450
      },
      "review_result": {
        "body_digest": "sha256:14d8a3cf343e723414eee4aa846ad44dd6472a62a66df9b07c6eb12be51642d8",
        "id": 5682750015
      }
    },
    "evidence_fingerprint": "sha256:bc85026d934b545f38cb7163386f7dbdec6c6a70e54165b5bb0ceedaa89b62ce",
    "head_sha": "d035d0987b83d97eef75c04ccb35fe788977a3db",
    "operation_identity": "sha256:fbfc03ddebcd54bafce739fae177e06fc072694063a794f67f950be120529559",
    "review_request_id": 5682713450,
    "review_result_id": 5682750015,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:2290d7486eb6ab89996f77d2c289d90798c5f3f4fe11dbe676bda4788b5c8637",
  "check_conclusions": [],
  "check_observations": [
    {
      "checks": [],
      "head_sha": "d035d0987b83d97eef75c04ccb35fe788977a3db",
      "id": "sha256:06f2361db4d9e589d4ffe3a867b4ef2b3576e6ff15e6d115ec464de0c2399cb1",
      "required_checks": [],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr154",
    "base_sha": "c510c326ad06f8d95b9b1d42cfe04339cc7009ba",
    "body_digest": "sha256:5abe3e78f8b650434e021b9807f8f23822719a4d243d418fab4f152a0fe4f1fc",
    "diff_digest": "sha256:2673e4b9d338d8e3243a88521f63c5172ee5a2f3b99dc991b6070c28231e806c",
    "head_ref": "pr155",
    "head_sha": "d035d0987b83d97eef75c04ccb35fe788977a3db",
    "pr": 155,
    "repository": "omry/reploy",
    "scope_authority": [
      {
        "digest": "sha256:47bb71c994c57aa7e3b5276a68bd5ec880bc0880e961f06544285ddd7e72500a",
        "path": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md"
      }
    ],
    "title_digest": "sha256:7133907d62fa112ba0922f70fe678fa1fe22d8072af28acd9fa129db721847d5"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-09-15T15:00:14Z",
      "base_ref": "pr154",
      "base_sha": "c510c326ad06f8d95b9b1d42cfe04339cc7009ba",
      "body_digest": "sha256:bf4600a343331e791ced03aa158cd5c2fa6eef66bb9f6c6d2f6f65783fe1842b",
      "created_at": "2026-09-15T15:10:20Z",
      "head_sha": "d035d0987b83d97eef75c04ccb35fe788977a3db",
      "id": 5682713450,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr154",
      "base_sha": "c510c326ad06f8d95b9b1d42cfe04339cc7009ba",
      "body_digest": "sha256:14d8a3cf343e723414eee4aa846ad44dd6472a62a66df9b07c6eb12be51642d8",
      "commit_id": "d035d0987b83d97eef75c04ccb35fe788977a3db",
      "id": 5682750015,
      "inline_message_ids": [],
      "request_comment_id": 5682713450,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-09-15T15:12:23Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:2290d7486eb6ab89996f77d2c289d90798c5f3f4fe11dbe676bda4788b5c8637",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:2673e4b9d338d8e3243a88521f63c5172ee5a2f3b99dc991b6070c28231e806c",
      "finding_ids": [],
      "invariants": [
        "portable Python final-image validation preserves every locked interpreter compatibility fact",
        "ordinary Python profiles retain compatible-version validation",
        "the exact reviewed head passes complete repository validation"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "d035d0987b83d97eef75c04ccb35fe788977a3db",
      "review_observation_id": null,
      "review_request_id": 5682713450,
      "review_result_id": 5682750015,
      "reviewed_head": "d035d0987b83d97eef75c04ccb35fe788977a3db",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review September 15, 2026 15:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T15:12:24.459588Z d035d09 Manual request
🔒 Security Review Completed 2026-09-15T15:12:19.414078Z d035d09 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Sep 15, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review d035d09

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: d035d0987b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Sep 15, 2026
@omry
omry merged commit 91799a0 into main Sep 15, 2026
8 checks passed
@omry
omry deleted the pr155 branch September 15, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant