Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 16 additions & 32 deletions docs/.review/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md
Original file line number Diff line number Diff line change
@@ -1,44 +1,28 @@
---
artifact: swe-design-review-attestation
schema_version: 3
scope_key: 4288e5336b3329ba610c14ee8eee2615dff4b85f8037754801b69b02d8cd4547
scope: {"kind": "path", "primary_target": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md", "repository": "/home/omry/dev/reploy", "selector": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md"}
review_content_identity_sha256: cce9da70072ca8936edc08ea263754f30c4c4c43748fdeccb3fe322903822693
target_content_identity_sha256: 02df853e94a6f2b9520b78f6cbf81a6a9b3e28706bc5e1e98c02952923f0e8ec
baseline_content_identity_sha256: dae0bab05a19ca44b34a2678c28ec00b315d23fdffd43035c6228ff18c3a3c14
target_documents: [{"path": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md", "repository": "/home/omry/dev/reploy", "sha256": "6d26d88967d14682b5628f211325c91cda966b55f74859efc0670dfbe44a901e"}]
baseline_documents: [{"path": "docs/PORTABLE_TOOL_DEFINITION_DESIGN.md", "repository": "/home/omry/dev/reploy", "sha256": "bd02f5450b2940b3a960f6419994aa9c4e5e65ccb4dc5365b4d17ac233b49d9d"}]
design_dependency_documents: [{"path": "docs/PORTABLE_TOOL_DEFINITION_DESIGN.md", "repository": "/home/omry/dev/reploy", "sha256": "bd02f5450b2940b3a960f6419994aa9c4e5e65ccb4dc5365b4d17ac233b49d9d"}]
document_repository: "/home/omry/dev/reploy"
schema_version: 4
scope_key: 6e41ee0e23cce83726e428ffd0200d01bd80afad080ceca7aa37fc184c2ece8b
scope: {"kind": "pr", "primary_target": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md", "repository": ".", "selector": "pr-142"}
review_content_identity_sha256: 420c290b22da1f05d04bc48e810d2312d4576a1b235055f6f2d82a8a5c5a05e7
target_content_identity_sha256: 6d0eaca0c38b8934f1858d76d6430ee4fb81b542792a33358c8a5afabf32f189
baseline_content_identity_sha256: cba65adf2b76aa499cd56fc0f3ed34649d32c18cf354cbc828795515a820769d
target_documents: [{"path": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md", "repository": ".", "sha256": "e7e9aea7520328b451074d634a9c437fdb790eeccfabb520f74b21f04ebcb495"}]
baseline_documents: [{"path": "docs/PORTABLE_TOOL_DEFINITION_DESIGN.md", "repository": ".", "sha256": "bd02f5450b2940b3a960f6419994aa9c4e5e65ccb4dc5365b4d17ac233b49d9d"}]
design_dependency_documents: [{"path": "docs/PORTABLE_TOOL_DEFINITION_DESIGN.md", "repository": ".", "sha256": "bd02f5450b2940b3a960f6419994aa9c4e5e65ccb4dc5365b4d17ac233b49d9d"}]
document_repository: "."
document_path: "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md"
document_revision_provenance: "a50aa980cdc0dc0afa754977c5b81508d0818050"
document_sha256: 6d26d88967d14682b5628f211325c91cda966b55f74859efc0670dfbe44a901e
document_revision_provenance: "243e45c5e3e0a57c20a7f23b0fe13035c4aadf7b"
document_sha256: e7e9aea7520328b451074d634a9c437fdb790eeccfabb520f74b21f04ebcb495
verdict: clean
attested_at: 2026-09-08T04:16:10Z
attested_at: 2026-09-11T07:58:31Z
---
<!-- swe-design-review-attestation:v3 -->
<!-- swe-design-review-attestation:v4 -->

# SWE design-review attestation

Review freshness is determined by the target and baseline document bytes
listed in the version-3 header. Revisions are provenance only.
listed in the version-4 header. Revisions are provenance only.

## Durable review state

## Standing decisions

### R1-5 — rejected — The provider-input recheck does not state the required abort transition

- Reason: Reject the finding's provider-input-change model. Blueprint and Reploy constraints plus all direct and indirect constraints introduced by candidate tool definitions are jointly solved from one immutable operation snapshot. Providers satisfy the selected complete constraint set; acquisition executes that selected solution. Conflicting constraints in the same resolution scope make a candidate ineligible, while genuinely isolated scopes may coexist. Remove the undefined provider-input recheck from both design and plan rather than specifying an abort transition for it.
- Actor: owner
- Decided: 2026-08-21T04:00:48Z
- Owner: omry
- Trigger: Owner confirmed immutable joint constraints, including tool-introduced constraints and scope isolation.

### R1-7 — rejected — The binding-default advertisement invariant has no owning acceptance case

- Reason: Reject the singular default-binding invariant. Model bindings as independently selectable contributions that may reference shared components of the same tool. When omitted, select bindings matching active application providers; allow an explicit binding list or explicit all; if several bindings remain possible without an active-provider match, require an explicit choice. Support typed intra-tool component dependencies now, while deferring general cross-tool dependencies until a concrete requirement justifies their solver complexity.
- Actor: owner
- Decided: 2026-08-21T04:36:53Z
- Owner: omry
- Trigger: Owner approved the Debian-like binding model and scoped dependencies to intra-tool composition.
No standing rejected or deferred decisions.
Loading
Loading