Cap ruff version to 0.15.x and bump GitHub Action to run on Node.js 24 - #236
Merged
Merged
Conversation
melissalinkert
approved these changes
Aug 7, 2026
melissalinkert
left a comment
melissalinkert
left a comment
Member
There was a problem hiding this comment.
Makes sense, as discussed separately. I imagine that the primary issue with ruff 0.16+ is https://astral.sh/blog/ruff-v0.16.0#better-default-rule-set, i.e. the significant increase in rules applied by default.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aim to fix the workflow failures exposed in #233 and unblock the review of individual PRs. An alternative approach would be to disabling this workflow entirely.
If we decide to keep the workflow, uncapping the version and fixing the errors would certainly require some work on the code-generation tool. Mindful that we have have had no significant work on
xsd-fuin the last 5+ years and based on previous experience, this would represent a significant commitment which does not align with the current priorities from the Bio-Formats team.