[Docs] Document the capacity high-water mark's hysteresis band - #21
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Documentation maintenance: ready. Unsuccessful content rounds: 0/3. Operational attempts: 0/3. Head: All edits serve the single concern (the high-water mark's damped-running-peak behavior and its hysteresisPercent knob) and every claim verifies against the OME checkout at bc1f94db: Track/TrackAll semantics in pkg/quota/capacity/highwater.go (growth believed at once; a drop believed only past the band, falling all the way to the observation; band<=0 disables damping, >=100 never lowers), the --capacity-hysteresis-percent flag (cmd/ome-quota-manager/main.go:173) with chart default 10 (charts/ome-quota-manager/values.yaml:124, passed in templates/deployment.yaml:98), the strict-comparison worked example (24 vs threshold 28.8 lowers the mark; 30 vs 28.8 keeps 32), CapacityExceeded against the mark with subtree freezing (capacitycheck.go, tree.Frozen, materialize.go), and mark persistence in root.Status.Capacity across restarts. The previously rejected clearing procedure is replaced by a paragraph that now matches executable behavior: capacity.Sum never observes a pair with zero installed capacity (acceleratorsOf skips zero allocatable), TrackAll's carry-forward ignores the band so damping off cannot lower a retained mark, reconcileCapacity's empty-pool samples preserve recorded marks, and the controller test "a pool that disappears keeps its mark" (capacity_test.go:434) exercises exactly this scenario; the advice to delete budgets naming a retired pool is sound since such budgets keep passing the capacity check against the stale mark. Output examples match attributeCapacity's cross product, the #lower-the-high-water-mark anchor matches the slugger, and the diff adds only Markdown to the one page with no nav/redirects/code edits. No review threads exist in the context, so none are reported addressed. Human review threads and CODEOWNER approval remain under repository policy. |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
What this PR does
When does the high-water mark that budgets are checked against come down after the cluster loses accelerators, and how do I tune that?
Why we need it
Source change: ome-projects/ome@37ce902
pkg/quota/capacity/highwater.go (Track, TrackAll, installed) in the current checkout: the mark is a running peak of installed capacity (allocatable plus capacity parked on cordoned or NotReady nodes); growth is believed immediately, and a drop is believed only when installed capacity falls more than --capacity-hysteresis-percent below the mark (cmd/ome-quota-manager/main.go:173; chart value quotaManager.capacity.hysteresisPercent, default 10 in charts/ome-quota-manager/values.yaml:114-124; 0 disables damping, >=100 never lowers the mark). A (resource, flavor) pair that stops reporting keeps its mark until it reaches zero. The current page src/lib/content/guides/operate-ome/accelerator-quota.md line 151 explains the mark only as 'also counts cordoned and not-Ready nodes, so it stays put while you drain nodes', which misses the damped-running-peak behavior — after a real decommission within the band the mark never comes down — and the Helm-value table (lines 286-291) omits hysteresisPercent. One concern: one stale explanation of the mark plus its single tuning knob, introduced by commit 18 which added highwater.go and the flag.
Scope: quota / capacity-high-water-mark-hysteresis. Other concerns are deferred.
How to test
git diff --checkand website content/link tests, type checks, lint and production build.Checklist
git commit -s)pnpm lint && pnpm check && pnpm test && pnpm buildpasses (run by the publisher on an isolated copy)