Skip to content

Fix pathing in dockerfile for start.sh#23

Open
licon4812 wants to merge 1 commit into
omaha-consulting:mainfrom
licon4812:docker-path-fix
Open

Fix pathing in dockerfile for start.sh#23
licon4812 wants to merge 1 commit into
omaha-consulting:mainfrom
licon4812:docker-path-fix

Conversation

@licon4812

Copy link
Copy Markdown

Relates to

This fix ensures that the start.sh is indeed a properly Linux-supported file when trying to run a container

@CLAassistant

CLAassistant commented Jan 9, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@mherrmann

Copy link
Copy Markdown
Contributor

Thanks. Wouldn't a better solution for this be a gitattributes file with *.sh text eol=lf ?

@licon4812

Copy link
Copy Markdown
Author

Thanks. Wouldn't a better solution for this be a gitattributes file with *.sh text eol=lf ?

Forgot that was even a thing 😅. I will give it a try

@licon4812

Copy link
Copy Markdown
Author

Thanks. Wouldn't a better solution for this be a gitattributes file with *.sh text eol=lf ?

I tried it locally and it still didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants