Harden tui launcher install and removal - #9150
Open
rihadroshan wants to merge 3 commits into
Open
Conversation
Port webapp-install's name and desktop-value guards to tui-install: a name can no longer nest the launcher (slash), climb out of the applications directory (../), or inject extra desktop-entry keys via a newline in Name/Comment/Exec/Icon. tui-remove now deletes the indexed launcher like webapp-remove, so entries left nested by older installs stay removable. Test: shell (tui-install-hardening-test.sh)
Harden tui launcher install and removal
rihadroshan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port webapp-install's name and desktop-value guards to tui-install.
Problem. omarchy-tui-install wrote its .desktop with raw values. A / in the app name became directory levels (unreachable by omarchy-tui-remove, and ../ escaped ~/.local/share/applications), and a newline could inject a second Exec= key. Its sibling omarchy-webapp-install already solves both with require_plain_name + desktop_string_escape.
Fix.
Verified: new test 7/7 pass; webapp-name, webapp-install-escaping, webapp-install, launcher-remove, desktop-entry-launch, refresh-config all green.