Repository navigation
Conversation
The fake source-highlight called /usr/bin/sleep, which NixOS and the Nix build sandbox lack, so the script exited at once and the test failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Low impact] This change appears safe to merge. SummaryThe shutdown test now finds
Reviews (1) · Last reviewed commit: "Find sleep on PATH in the shutdown test" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_quit_drains_active_renderers_before_qt_teardownwrites a fakesource-highlightthat calls/usr/bin/sleep 2. NixOS and the Nix build sandbox have no/usr/bin/sleep, so the fake tool exits right away, the render jobs finish before the quit, and the test fails with "The test must exercise quitting before render jobs finish".This calls plain
sleepinstead. The test only puts itstools/directory in front ofPATH, so the systemsleepis still found on Arch.I hit this packaging Hype 0.7.1 for Nixpkgs (NixOS/nixpkgs#587621): without the change the test fails in the sandbox, with it the suite passes there.
This change was made with help from Claude Code.