Skip to content

Find sleep on PATH in the shutdown test - #63

Open
kleinbem wants to merge 1 commit into
omacom:masterfrom
kleinbem:sleep-on-path
Open

kleinbem wants to merge 1 commit into
omacom:masterfrom
kleinbem:sleep-on-path

Conversation

@kleinbem

Copy link
Copy Markdown

test_quit_drains_active_renderers_before_qt_teardown writes a fake source-highlight that calls /usr/bin/sleep 2. NixOS and the Nix build sandbox have no /usr/bin/sleep, so the fake tool exits right away, the render jobs finish before the quit, and the test fails with "The test must exercise quitting before render jobs finish".

This calls plain sleep instead. The test only puts its tools/ directory in front of PATH, so the system sleep is still found on Arch.

I hit this packaging Hype 0.7.1 for Nixpkgs (NixOS/nixpkgs#587621): without the change the test fails in the sandbox, with it the suite passes there.

This change was made with help from Claude Code.

The fake source-highlight called /usr/bin/sleep, which NixOS and the Nix
build sandbox lack, so the script exited at once and the test failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

The shutdown test now finds sleep through PATH instead of requiring /usr/bin/sleep.

  • The shutdown test finds sleep by its command name.

Reviews (1) · Last reviewed commit: "Find sleep on PATH in the shutdown test" · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant