Repository navigation
Make thumbnails of files on other machines - #166
Merged
Merged
Conversation
A file on another machine (a Tailscale machine's, mounted by GVfs) got
no thumbnail and no preview from thumbnailers given a URI: they ask GIO
for the file, and GIO turns a path under the GVfs mounts back into its
network address, sftp://…, which most can't open. Papers, which makes
PDFs' thumbnails, said so ("not an absolute URI using the file scheme"),
and every remote PDF showed the plain icon in its row and its details.
Such a file now goes to the thumbnailer by a link in its scratch folder,
named with the file's extension, which reads through the mount the same
and which GIO leaves a file. A remote PDF's 128 and 1024 pixel
thumbnails now take 150ms between them.
Its failure was remembered, so it would never have been tried again.
What failed is now remembered with the round it failed in, and one from
before this is tried once more.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The follow-up appears safe to merge; no new blocking issues were found. SummaryRemote files reach thumbnailers through a temporary link, and older failure records allow another attempt. The follow-up adds a focused test for remote and local paths.
Reviews (2) · Last reviewed commit: "Test that a file on another machine reac..." · Reviewed by Greptile |
Where GVfs mounts other machines is now given to Thumbnails (the real place unless a test gives its own), so a test can put a file there: its fake thumbnailer, given a URI, records it, and the test checks it's a file:// link with the file's extension, outside the mounts, while the thumbnail is kept under the file's own path, and that a file here goes as it is. Without the link the test fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A file on another machine (a Tailscale machine's, mounted by GVfs) got no thumbnail and no preview from thumbnailers given a URI: they ask GIO for the file, and GIO turns a path under the GVfs mounts back into its network address, sftp://…, which most can't open. Papers, which makes PDFs' thumbnails, said so ("not an absolute URI using the file scheme"), and every remote PDF showed the plain icon in its row and its details.
Such a file now goes to the thumbnailer by a link in its scratch folder, named with the file's extension, which reads through the mount the same and which GIO leaves a file. A remote PDF's 128 and 1024 pixel thumbnails now take 150ms between them.
Its failure was remembered, so it would never have been tried again. What failed is now remembered with the round it failed in, and one from before this is tried once more.
🤖 Generated with Claude Code