Repository navigation
Show search results as they're found, with a spinner while it looks - #165
Merged
Merged
Conversation
A search went through every folder below before showing anything, so in a big tree the window kept showing the folder searched, with no sign of work, for a long while. It now shows a new search's matches as it finds them, a batch at most every tenth of a second, each put straight into its place in the folder's order, so the list grows without jumping and the cursor goes to the first match as soon as there is one. A new search starts from an empty list rather than the folder searched; the same search run again (the folder changed under it) leaves its matches up and swaps them only if they've changed. While it looks, a spinner turns in the search field and an empty list says Searching… rather than Nothing matches. Searching /usr for gnome- showed 149 of its 258 matches at 250ms, where it showed none until 769ms. A new test checks the matches come in batches while the walk goes on, that they add up to the whole, and how the model shows a new search and the same one again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The changes appear safe to merge. SummarySearch results now appear in batches while a spinner shows that the search is still running.
Both previous findings are addressed. No new actionable issues were found in the changes since the previous review. Reviews (2) · Last reviewed commit: "Tell a search's matches through quiet st..." · Reviewed by Greptile |
…es from the selection Matches were told only as another was found, so one found early, before a long walk through folders with no more matches, stayed hidden until the search ended. The time is now checked at every entry walked. The same search run again (the folder changed under it) swapped in its new matches but kept selecting those no longer found, so the selection's count was off. It now keeps only what's still listed, as a re-read of a folder does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A search went through every folder below before showing anything, so in a big tree the window kept showing the folder searched, with no sign of work, for a long while.
It now shows a new search's matches as it finds them, a batch at most every tenth of a second, each put straight into its place in the folder's order, so the list grows without jumping and the cursor goes to the first match as soon as there is one. A new search starts from an empty list rather than the folder searched; the same search run again (the folder changed under it) leaves its matches up and swaps them only if they've changed. While it looks, a spinner turns in the search field and an empty list says Searching… rather than Nothing matches.
Searching /usr for gnome- showed 149 of its 258 matches at 250ms, where it showed none until 769ms. A new test checks the matches come in batches while the walk goes on, that they add up to the whole, and how the model shows a new search and the same one again.
🤖 Generated with Claude Code