Repository navigation
Group the keyboard shortcuts, with keys as keycaps - #159
Merged
Merged
Conversation
[Low impact] This PR appears safe to merge. SummaryGroups shortcuts by task and draws keys as keycaps.
No new actionable issues found. Reviews (4) · Last reviewed commit: "Fit the shortcuts to a narrow window" · Reviewed by Greptile |
dhh
force-pushed
the
sidebar-folder-menu
branch
from
November 17, 2026 15:08
e08947d to
d76871f
Compare
dhh
force-pushed
the
sidebar-folder-menu
branch
2 times, most recently
from
November 17, 2026 15:50
0542498 to
548b567
Compare
The shortcuts were one long list in no order, with descriptions running onto second lines and keys written out as text. They're now in groups (Moving around, Selecting, Files, View, Window), each with a small heading as the sidebar's sections have. Each shortcut says what it does in a line, with its keys as keycaps on the right; the ways to do it are set apart by a slash, and what's done with the mouse (click, drag) is a word rather than a key. The groups flow into two or three columns as the window allows, about as long as each other, and "Escape closes" sits in the corner. The descriptions are shorter, new strings; other languages show them in English until the next translation sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…that needs it
The preview window's shortcuts were still given in the old form, so
QML refused the window ("Cannot assign to non-existent property
'shortcuts'") and no file could be previewed. They're now a group of
the same form, and a new test loads the preview window as the app does,
shortcuts shown.
Cut, paste, the views and the tile sizes showed bare X, V, 2, 3, - and
0 after the first Ctrl, keys that do nothing alone. Every way shown now
has its Ctrl.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A column of shortcuts was 400 wide whatever the window, and the preview window can be 480 wide, leaving 360: the keycaps at the right were cut off, with no way to scroll to them. A column now narrows to the room there is (to 240 at the least), its descriptions eliding first, and what still doesn't fit scrolls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shortcuts were one long list in no order, with descriptions running onto second lines and keys written out as text.
They're now in groups (Moving around, Selecting, Files, View, Window), each with a small heading as the sidebar's sections have. Each shortcut says what it does in a line, with its keys as keycaps on the right; the ways to do it are set apart by a slash, and what's done with the mouse (click, drag) is a word rather than a key. The groups flow into two or three columns as the window allows, about as long as each other, and "Escape closes" sits in the corner.
The descriptions are shorter, new strings; other languages show them in English until the next translation sync.
Stacked on #158: this PR shows only its own commit.
🤖 Generated with Claude Code