Skip to content

Group the keyboard shortcuts, with keys as keycaps - #159

Merged
dhh merged 3 commits into
mainfrom
shortcuts-page
Nov 17, 2026
Merged

dhh merged 3 commits into
mainfrom
shortcuts-page

Conversation

@dhh

@dhh dhh commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The shortcuts were one long list in no order, with descriptions running onto second lines and keys written out as text.

They're now in groups (Moving around, Selecting, Files, View, Window), each with a small heading as the sidebar's sections have. Each shortcut says what it does in a line, with its keys as keycaps on the right; the ways to do it are set apart by a slash, and what's done with the mouse (click, drag) is a word rather than a key. The groups flow into two or three columns as the window allows, about as long as each other, and "Escape closes" sits in the corner.

The descriptions are shorter, new strings; other languages show them in English until the next translation sync.

Stacked on #158: this PR shows only its own commit.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Groups shortcuts by task and draws keys as keycaps.

  • Folio’s shortcut guide groups actions and shows each key as a keycap.

No new actionable issues found.

Reviews (4) · Last reviewed commit: "Fit the shortcuts to a narrow window" · Reviewed by Greptile

Comment thread src/HelpOverlay.qml Resolved
Comment thread src/HelpOverlay.qml Resolved
Comment thread src/HelpOverlay.qml Resolved
@dhh
dhh force-pushed the sidebar-folder-menu branch 2 times, most recently from 0542498 to 548b567 Compare November 17, 2026 15:50
Base automatically changed from sidebar-folder-menu to main November 17, 2026 15:50
dhh and others added 3 commits November 17, 2026 16:50
The shortcuts were one long list in no order, with descriptions running
onto second lines and keys written out as text.

They're now in groups (Moving around, Selecting, Files, View, Window),
each with a small heading as the sidebar's sections have. Each shortcut
says what it does in a line, with its keys as keycaps on the right; the
ways to do it are set apart by a slash, and what's done with the mouse
(click, drag) is a word rather than a key. The groups flow into two or
three columns as the window allows, about as long as each other, and
"Escape closes" sits in the corner.

The descriptions are shorter, new strings; other languages show them in
English until the next translation sync.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…that needs it

The preview window's shortcuts were still given in the old form, so
QML refused the window ("Cannot assign to non-existent property
'shortcuts'") and no file could be previewed. They're now a group of
the same form, and a new test loads the preview window as the app does,
shortcuts shown.

Cut, paste, the views and the tile sizes showed bare X, V, 2, 3, - and
0 after the first Ctrl, keys that do nothing alone. Every way shown now
has its Ctrl.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A column of shortcuts was 400 wide whatever the window, and the preview
window can be 480 wide, leaving 360: the keycaps at the right were cut
off, with no way to scroll to them. A column now narrows to the room
there is (to 240 at the least), its descriptions eliding first, and
what still doesn't fit scrolls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh
dhh merged commit a2c6395 into main Nov 17, 2026
2 checks passed
@dhh
dhh deleted the shortcuts-page branch November 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant