feat: add TimeLock contract with queue/execute/cancel#5
Merged
Conversation
Single-admin timelock used to practice vm.warp timing tests. Custom errors throughout (NotAdmin / AlreadyQueued / NotQueued / TooEarly / CallFailed). Operation ID hashes (target, value, data, salt) so the same call can be queued multiple times via distinct salts.
Owner
Author
|
Reviewed - the salt-in-id design avoids the 'same call can never be queued twice' footgun. Tests cover the queue/execute/cancel happy paths plus all four custom-error reverts. Merging. |
oliv3rdrt
added a commit
that referenced
this pull request
Jun 27, 2026
Single-admin timelock used to practice vm.warp timing tests. Custom errors throughout (NotAdmin / AlreadyQueued / NotQueued / TooEarly / CallFailed). Operation ID hashes (target, value, data, salt) so the same call can be queued multiple times via distinct salts. Co-authored-by: Oliver Anyanwu <oliver.anyanwu@aol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/TimeLock.sol: minimal admin-gated timelock.queuerecords an eta,executecalls the target onceblock.timestamp >= eta,cancelinvalidates an entry. Operation id =keccak256(target, value, data, salt)so the same call can be queued more than once via distinct salts.NotAdmin,AlreadyQueued,NotQueued,TooEarly,CallFailed).test/TimeLock.t.sol: 7 unit + 1 fuzz test usingvm.warpto exercise the timing edges. Executes againstCounterto keep the target trivial.Test plan
forge test --match-contract TimeLockTest- 8/8 pass (1000 fuzz runs)forge test- 41/41, no regressions