Skip to content

docs: clarify confirm dismissal and modal lifecycle in README - #26

Merged
okyrychenko-dev merged 3 commits into
mainfrom
docs/readme-modal-outcomes
Oct 2, 2026
Merged

okyrychenko-dev merged 3 commits into
mainfrom
docs/readme-modal-outcomes

Conversation

@okyrychenko-dev

@okyrychenko-dev okyrychenko-dev commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Put the choice between confirm, custom modals, registry, and renderer near the top.
  • Clarify that built-in Cancel and Escape resolve with a typed result, while programmatic dismissal, closeAll, and provider teardown reject.
  • Add examples for handling ModalDismissError, caller unmount cleanup, once-only settlement, Strict Mode, and the renderer seam.
  • Move the competitor comparison below the usage guides.

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@okyrychenko-dev
okyrychenko-dev marked this pull request as ready for review October 2, 2026 06:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T06:13:48.443481Z b08f586 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c46e3d0b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md Outdated
@okyrychenko-dev
okyrychenko-dev merged commit 33a65f0 into main Oct 2, 2026
5 checks passed
@okyrychenko-dev
okyrychenko-dev deleted the docs/readme-modal-outcomes branch October 2, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant