Skip to content

feat: allow omitted void modal input - #23

Merged
okyrychenko-dev merged 1 commit into
mainfrom
feature/optional-void-modal-input
Sep 13, 2026
Merged

okyrychenko-dev merged 1 commit into
mainfrom
feature/optional-void-modal-input

Conversation

@okyrychenko-dev

Copy link
Copy Markdown
Owner

Summary

  • add ModalOpenArgs<TInput> to make input optional for modal definitions using void or undefined
  • apply the conditional tuple consistently across modal managers, lifecycle APIs, registered definitions, and typed registries
  • preserve required input arguments for every other input type
  • preserve the inferred ModalHandle<TResult> return type when input is omitted
  • verify both valid inputless calls and invalid missing-input calls through the packed-consumer typecheck
  • update internal fixtures, stories, benchmarks, and documentation to use the shorter inputless syntax
  • export ModalOpenArgs as part of the public type API
  • introduce no ESLint suppressions, type assertions, any, or runtime behavior changes

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@okyrychenko-dev
okyrychenko-dev merged commit 9c804a5 into main Sep 13, 2026
5 checks passed
@okyrychenko-dev
okyrychenko-dev deleted the feature/optional-void-modal-input branch September 13, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant