fix: expirePasswordAndGetTemporaryPassword deserializes response as U… - #504
Open
manmohan-shaw-okta wants to merge 1 commit into
Open
fix: expirePasswordAndGetTemporaryPassword deserializes response as U…#504manmohan-shaw-okta wants to merge 1 commit into
manmohan-shaw-okta wants to merge 1 commit into
Conversation
…ser instead of TempPassword
The expire_password_with_temp_password endpoint returns {"tempPassword": "..."},
but the generated response processor deserialized it against the User model,
silently dropping the tempPassword property and returning it empty.
Fix the response schema/deserialization to use TempPassword, matching the
pre-v7.1.1 behavior, and strengthen the existing unit tests to assert the
temp password value is actually preserved.
OKTA-1206504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ser instead of TempPassword
The expire_password_with_temp_password endpoint returns {"tempPassword": "..."}, but the generated response processor deserialized it against the User model, silently dropping the tempPassword property and returning it empty.
Fix the response schema/deserialization to use TempPassword, matching the pre-v7.1.1 behavior, and strengthen the existing unit tests to assert the temp password value is actually preserved.
OKTA-1206504
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers