Skip to content

Read Lua team ID from repository variables #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ojowwalker77 merged 1 commit into from
Jul 17, 2026
Merged

Read Lua team ID from repository variables #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
APPLE_API_KEY: ${{ secrets.APPLE_API_KEY_P8 || secrets.APPLE_API_KEY }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER_ID || secrets.APPLE_API_ISSUER }}
TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
TEAM_ID: ${{ secrets.APPLE_TEAM_ID || vars.APPLE_TEAM_ID }}
SPARKLE_PRIVATE_KEY: ${{ secrets.SPARKLE_PRIVATE_KEY }}
run: |
for name in CERTIFICATE_P12 CERTIFICATE_PASSWORD APPLE_API_KEY APPLE_API_KEY_ID APPLE_API_ISSUER TEAM_ID SPARKLE_PRIVATE_KEY; do
Expand Down
5 changes: 4 additions & 1 deletion RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ from a dirty or unverified source state.
- `APPLE_API_KEY_P8`
- `APPLE_API_KEY_ID`
- `APPLE_API_ISSUER_ID`
- `APPLE_TEAM_ID`
- `SPARKLE_PRIVATE_KEY`

For the first Lua release, the workflow also accepts the existing legacy
aliases `MACOS_CERTIFICATE_P12`, `APPLE_API_KEY`, and `APPLE_API_ISSUER`.
Migrate those values to the preferred names above before removing the aliases.

## Required repository variables

- `APPLE_TEAM_ID`

`PHI_FRAMEWORK_VERSION` remains an optional repository variable. Any version
other than the repository default also requires `PHI_FRAMEWORK_SHA256` and
may use `PHI_FRAMEWORK_URL`. The release refuses an unpinned framework.
Expand Down
Loading