Skip to content

Fix retrieving files from git sources by overriding fetch() - #3

Open
nikitalita wants to merge 1 commit into
ohzinteractive:mainfrom
nikitalita:fetch-vscode
Open

Fix retrieving files from git sources by overriding fetch()#3
nikitalita wants to merge 1 commit into
ohzinteractive:mainfrom
nikitalita:fetch-vscode

Conversation

@nikitalita

Copy link
Copy Markdown

while the previous method of just streaming git located files as base64 works for single-file GLB scenes, it doesn't work if the scenes have external dependencies.

We can fix this by doing two things:

  • override fetch() on the window to our own version that communicates with the extension to retrieve git scheme files.
  • override loader.manager.setURLModifier to set the proper query data for git scheme files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant