Fix retrieving files from git sources by overriding fetch() - #3
Open
nikitalita wants to merge 1 commit into
Open
Fix retrieving files from git sources by overriding fetch()#3nikitalita wants to merge 1 commit into
fetch()#3nikitalita wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while the previous method of just streaming
gitlocated files as base64 works for single-fileGLBscenes, it doesn't work if the scenes have external dependencies.We can fix this by doing two things:
fetch()on the window to our own version that communicates with the extension to retrievegitscheme files.loader.manager.setURLModifierto set the proper query data forgitscheme files.