Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,13 @@ public static Offering parseOffering(String json) {
}

public static ProblemDetails parseProblemDetails(String json) {
return parse(json, "problem-details.schema.json", "Problem Details", ProblemDetails.class);
ProblemDetails problem = parse(json, "problem-details.schema.json", "Problem Details", ProblemDetails.class);
String expectedType = "https://offeringprotocol.org/problems/"
+ problem.code().toLowerCase(Locale.ROOT).replace('_', '-');
if (!expectedType.equals(problem.type())) {
throw semanticError("Problem Details", "type must correspond to the problem code", "/type");
}
return problem;
}

public static SearchRequests.Collections parseCollectionSearchRequest(String json) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,20 @@ void rejectsInvalidServiceDocuments() {
assertTrue(!exception.issues().isEmpty());
}

@Test
void rejectsProblemTypesThatDoNotCorrespondToTheCode() {
String problem = """
{
"code":"NOT_FOUND",
"status":404,
"title":"Not found",
"type":"https://offeringprotocol.org/problems/validation-failed"
}
""";

assertThrows(OdpValidationException.class, () -> OdpJson.parseProblemDetails(problem));
}

@Test
void enforcesServiceDocumentSemanticConstraints() {
String duplicateLocalization =
Expand Down